From: Eli Cohen <elic@nvidia.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Cindy Lu <lulu@redhat.com>,
<virtualization@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance
Date: Sun, 6 Dec 2020 08:54:22 +0200 [thread overview]
Message-ID: <20201206065422.GA161813@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <b74596fe-fff3-2144-b41a-b9898b6933da@redhat.com>
On Fri, Dec 04, 2020 at 10:53:28AM +0800, Jason Wang wrote:
>
> On 2020/12/3 下午8:24, Eli Cohen wrote:
> > > > It is mentioned in Parav's patchset that this will be coming in a
> > > > subsequent patch to his vdpa tool.
> > > So I think kernel has two options:
> > > - require a mac when device is created, we supply it to guest
> > Yes, the driver should always set VIRTIO_NET_F_MAC and provide a MAC -
> > either random or whatever configured using the vdpa too.
>
>
> A questions here, I think current mlx5 vdpa works for VF only. So I think
> the VF should have a given MAC? If yes, can we use that MAC?
>
The MAC assigned to VF is by the NIC implementation. Both ther regular
NIC driver and the VDPA implementation can co-exist so we can't use the
NIC's MAC for VDPA. We want to steer traffic based on its destination
MAC address to either VDPA or regular NIC.
next prev parent reply other threads:[~2020-12-06 6:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 6:43 [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance Eli Cohen
2020-11-29 20:08 ` Michael S. Tsirkin
2020-11-30 6:27 ` Eli Cohen
2020-11-30 9:00 ` Michael S. Tsirkin
2020-11-30 9:27 ` Eli Cohen
2020-11-30 9:33 ` Michael S. Tsirkin
2020-11-30 10:41 ` Cindy Lu
2020-11-30 15:33 ` Michael S. Tsirkin
2020-12-01 9:23 ` Cindy Lu
2020-12-01 11:32 ` Michael S. Tsirkin
2020-12-02 2:27 ` Cindy Lu
2020-12-02 4:18 ` Jason Wang
2020-12-02 5:57 ` Eli Cohen
2020-12-02 9:23 ` Michael S. Tsirkin
2020-12-02 12:12 ` Eli Cohen
2020-12-02 12:17 ` Michael S. Tsirkin
2020-12-02 13:00 ` Jason Wang
2020-12-02 13:07 ` Michael S. Tsirkin
2020-12-02 13:33 ` Jason Wang
2020-12-02 13:48 ` Jason Wang
2020-12-02 22:00 ` Michael S. Tsirkin
2020-12-03 6:49 ` Eli Cohen
2020-12-03 10:44 ` Michael S. Tsirkin
2020-12-03 12:09 ` Eli Cohen
2020-12-03 12:15 ` Michael S. Tsirkin
2020-12-03 12:24 ` Eli Cohen
2020-12-04 2:53 ` Jason Wang
2020-12-06 6:54 ` Eli Cohen [this message]
2020-12-02 9:30 ` Michael S. Tsirkin
2020-12-02 12:56 ` Jason Wang
2020-12-02 13:04 ` Michael S. Tsirkin
2020-12-02 13:41 ` Jason Wang
2020-11-30 11:51 ` Eli Cohen
2020-11-30 15:30 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206065422.GA161813@mtl-vdi-166.wap.labs.mlnx \
--to=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).