From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D6AC433FE for ; Mon, 7 Dec 2020 06:34:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25BD9225A9 for ; Mon, 7 Dec 2020 06:34:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725924AbgLGGeZ (ORCPT ); Mon, 7 Dec 2020 01:34:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbgLGGeZ (ORCPT ); Mon, 7 Dec 2020 01:34:25 -0500 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBD21C0613D1 for ; Sun, 6 Dec 2020 22:33:44 -0800 (PST) Received: by mail-pj1-x1044.google.com with SMTP id h7so6489581pjk.1 for ; Sun, 06 Dec 2020 22:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=unfBbNCI0m3ptB2CCZebMmZ2Tw9oIvAqWo/oBXmpaOk=; b=c6g8eg9Zquy73mzH0bVNuB3jifwIQLnBnawoOZMdZnDFAOmT2WgFjPn7i7AnxuIRp1 Oi9QYTQ3JvTx8Gyf6qX3Rno1iiMHDIJW69Lyjv3ZO6lwM7JL+yKhFEZ/oabzPyPa8X5S ZHsGAsU6Quctd3SEaaNA0sDbyrCwv7xzfIAcgXH/aDd8sJd9C0mVX90AD9tq1Yg9Ritv hw0s9rMX0h3qNFkY7lU18Z24ZY66Vl67pS/c2B4H0KWbgZ7BAy0LuT0yQ9R0Za4/MzUq s+a5bLrGXC7U++7OUziNyBFhuqM7yczFutd2yK76KyRXxwNIe9SJO4ofYjoOWXtlT8UD Qthw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=unfBbNCI0m3ptB2CCZebMmZ2Tw9oIvAqWo/oBXmpaOk=; b=MEfCu92fJ94ST1R4xalZnO4RzCWcUiog/XxYeeyuix6uB3zsVnL5q5RZr3G7KPaZ9s lFmUw492oCHDw8wgr+CA5QyRl/mio1+FHMKc/Td8aLE8EcHvmTlVdl19ybnbVeBu32+M NVaGLjq72LrvggbgE4O9BY72JvxaRF8O954PEDdfixnzkz/wVEeXasbvbarbjUV/4EL0 oZEMB9YgzD6C45tM/Gud2bqxHLOSebVlXVc6YIJANJwc44ftFHP3q0cJfHSuG/dRFgeE 80SyAoNKYBQFO0N0LkYl57FUA41i9md4RKWUOuCn1zp7MnWVlNcWu44TocOd8K7km8C+ xgmg== X-Gm-Message-State: AOAM53320TKmYCmrIJiD4fCr5VsFgtM2mSFxrCH9fbkTQFVsfh5wNe/u 8mjDlOcodWFXaG+vJYCInGVTdg== X-Google-Smtp-Source: ABdhPJxXmYsMI7E+hyqpdvOd5tLHP/tJhmopVByXPoaWhwUHfY20BsFmhK2d9+/88SHFOpRHxyc+uA== X-Received: by 2002:a17:90a:5b18:: with SMTP id o24mr1636726pji.120.1607322824487; Sun, 06 Dec 2020 22:33:44 -0800 (PST) Received: from localhost ([122.172.136.109]) by smtp.gmail.com with ESMTPSA id m4sm14207689pfd.203.2020.12.06.22.33.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Dec 2020 22:33:43 -0800 (PST) Date: Mon, 7 Dec 2020 12:03:42 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Sudeep Holla , Arnd Bergmann , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: scmi: add COMMON_CLK dependency Message-ID: <20201207063342.fi5ms67wdy4aaqpf@vireshk-i7> References: <20201203225550.1478195-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203225550.1478195-1-arnd@kernel.org> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-12-20, 23:55, Arnd Bergmann wrote: > From: Arnd Bergmann > > Wtihout CONFIG_COMMON_CLK, the scmi driver fails to link: > > arm-linux-gnueabi-ld: drivers/cpufreq/scmi-cpufreq.o: in function `scmi_cpufreq_probe': > scmi-cpufreq.c:(.text+0x20c): undefined reference to `devm_of_clk_add_hw_provider' > arm-linux-gnueabi-ld: scmi-cpufreq.c:(.text+0x22c): undefined reference to `of_clk_hw_simple_get' > > Add a Kconfig dependency for it. > > Fixes: 8410e7f3b31e ("cpufreq: scmi: Fix OPP addition failure with a dummy clock provider") > Signed-off-by: Arnd Bergmann > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 1f73fa75b1a0..434ef03d2762 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -264,6 +264,7 @@ config ARM_SA1110_CPUFREQ > config ARM_SCMI_CPUFREQ > tristate "SCMI based CPUfreq driver" > depends on ARM_SCMI_PROTOCOL || COMPILE_TEST > + depends on COMMON_CLK > select PM_OPP > help > This adds the CPUfreq driver support for ARM platforms using SCMI This is already fixed by: commit f943849f7206 ("cpufreq: scmi: Fix build for !CONFIG_COMMON_CLK") -- viresh