linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Icenowy Zheng <icenowy@aosc.io>,
	Samuel Holland <samuel@sholland.org>,
	devicetree <devicetree@vger.kernel.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] Re: [PATCH 3/3] arm64: allwinner: dts: a64: add DT for PineTab developer sample
Date: Mon, 7 Dec 2020 11:07:03 +0100	[thread overview]
Message-ID: <20201207100703.tfavhmexbtrzucry@gilmour> (raw)
In-Reply-To: <CAJiuCceq4J=9obLTJ9TL=ci55bupc552ymGOH9z-feNTbq0hSQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4448 bytes --]

On Sun, Dec 06, 2020 at 10:03:16PM +0100, Clément Péron wrote:
> Hi Maxime
> 
> On Tue, 1 Dec 2020 at 11:35, Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Sat, Nov 28, 2020 at 10:07:27PM +0100, Clément Péron wrote:
> > > Hi Maxime, Icenowy,
> > >
> > > On Sat, 28 Nov 2020 at 12:59, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > >
> > > >
> > > >
> > > > 于 2020年11月28日 GMT+08:00 下午7:54:04, "Clément Péron" <peron.clem@gmail.com> 写到:
> > > > >Hi Icenowy,
> > > > >
> > > > >On Sat, 28 Nov 2020 at 12:28, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > > >>
> > > > >> 在 2020-11-28星期六的 11:38 +0100,Maxime Ripard写道:
> > > > >> > On Mon, Nov 23, 2020 at 09:10:38PM +0800, Icenowy Zheng wrote:
> > > > >> > > > > > > > Okay. But I'm not satisfied with a non-public sample
> > > > >> > > > > > > > occupies
> > > > >> > > > > > > > the pinetab name. Is rename it to pinetab-dev and add a
> > > > >> > > > > > > > pinetab-retail okay?
> > > > >> > > > > > >
> > > > >> > > > > > > To me, naming the production version anything but
> > > > >"pinetab"
> > > > >> > > > > > > isn't
> > > > >> > > > > > > satisfying either.
> > > > >> > > > > >
> > > > >> > > > > > I understand where you're coming from, but the point I was
> > > > >> > > > > > making my
> > > > >> > > > > > previous mail is precisely that it's not really possible.
> > > > >> > > > > >
> > > > >> > > > > > You want to name the early adopter version _the_ production
> > > > >> > > > > > version. Let's assume the hardware changes again between
> > > > >the
> > > > >> > > > > > early
> > > > >> > > > > > adopter and mass-production version. Which one will be
> > > > >_the_
> > > > >> > > > > > production version? The early-adopter or the mass-produced
> > > > >> > > > > > one?
> > > > >> > > > > >
> > > > >> > > > > > There's really no good answer here, and both would suck in
> > > > >> > > > > > their
> > > > >> > > > > > own way. The only way to deal with this is to simply avoid
> > > > >> > > > > > defining one version as the one true board, and just
> > > > >loading
> > > > >> > > > > > the
> > > > >> > > > > > proper DT in u-boot based on whatever clue we have of the
> > > > >> > > > > > hardware
> > > > >> > > > > > revision.
> > > > >> > > > > Then will it be okay to rename current pinetab DT to
> > > > >> > > > > pinetab-sample and then introduce new DTs all with suffixes?
> > > > >> > > >
> > > > >> > > > No. From my previous mail:
> > > > >> > >
> > > > >> > > It can be seen as dropping the PineTab DT and introduce new DTs
> > > > >> > > with
> > > > >> > > suffix.
> > > > >> > >
> > > > >> > > Do we have rule that we cannot drop boards?
> > > > >> >
> > > > >> > Are you really arguing that removing a DT and then adding an
> > > > >> > identical
> > > > >> > one under a different name is not renaming it?
> > > > >>
> > > > >> Then we can just keep confusing name?
> > > > >
> > > > >Sorry maybe I missed some information
> > > > >But why don't you do like pinephone?
> > > >
> > > > They're the same board revision with different LCD panels.
> > >
> > > I just ask Pine64 about this and here is the reply :
> > > "The PineTab LCD panel change was a last minutes before production
> > > starts that vendor advise us switch over to new LCD controller due to
> > > EoL concern".
> > >
> > > "Pine64 communication" is not so bad we just need to ask and they reply :)
> > >
> > > So the issue is not that the Product was not finalized but that one
> > > component arrives in EoL.
> > > This could also happens during a running production.
> >
> > Like you said, it can happen pretty much any time, for any reason, so
> > the intent doesn't really matter here.
> 
> Agree, that was more to support Pin64 guys here.
> 
> As pinetab compatible can't be reused maybe somethings like this :
> sun50i-a64-pinetab.dtsi
> sun50i-a64-pinetab-1.0-early-adopter.dtb
> sun50i-a64-pinetab-1.0.dtb or sun50i-a64-pinetab-retail.dtb. But
> retail is like prod it's not explicit.
> 
> What do you think ?

I already said what I think multiple times in this thread: the DT that
has been merged for the early adopter, devs, whatever, won't be renamed.
As far as I'm concerned, I don't care about the name that is picked for
the new version as long as everyone is clear on the fact that that name
won't change ever either.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2020-12-07 10:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-07 12:49 [PATCH 0/3] Switch PineTab DT LCD panel to retail one Icenowy Zheng
2020-11-07 12:50 ` [PATCH 1/3] arm64: allwinner: dts: a64: pinetab: switch LCD panel to production one Icenowy Zheng
2020-11-07 12:52 ` [PATCH 2/3] dt-bindings: arm: sunxi: add PineTab developer sample DT binding Icenowy Zheng
2020-11-09 22:02   ` Rob Herring
2020-11-07 12:53 ` [PATCH 3/3] arm64: allwinner: dts: a64: add DT for PineTab developer sample Icenowy Zheng
2020-11-10 10:39   ` Maxime Ripard
2020-11-10 10:41     ` Icenowy Zheng
2020-11-16 15:55       ` Maxime Ripard
2020-11-16 18:36         ` [linux-sunxi] " Icenowy Zheng
2020-11-20 15:59           ` Maxime Ripard
2020-11-20 23:30             ` Icenowy Zheng
2020-11-21  2:51               ` Samuel Holland
2020-11-23 11:15                 ` Maxime Ripard
2020-11-23 11:25                   ` Icenowy Zheng
2020-11-23 12:53                     ` Maxime Ripard
2020-11-23 13:10                       ` Icenowy Zheng
2020-11-28 10:38                         ` Maxime Ripard
2020-11-28 11:28                           ` Icenowy Zheng
2020-11-28 11:54                             ` Clément Péron
2020-11-28 11:59                               ` Icenowy Zheng
2020-11-28 21:07                                 ` Clément Péron
2020-12-01 10:35                                   ` Maxime Ripard
2020-12-06 21:03                                     ` Clément Péron
2020-12-07 10:07                                       ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207100703.tfavhmexbtrzucry@gilmour \
    --to=maxime@cerno.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=peron.clem@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).