From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/8] dt-bindings: display: simple: fix alphabetical order for EDT compatibles
Date: Mon, 7 Dec 2020 12:06:16 +0100 [thread overview]
Message-ID: <20201207110616.r47utgzdkw3wrply@pengutronix.de> (raw)
In-Reply-To: <20201205193229.GF332836@ravnborg.org>
On Sat, Dec 05, 2020 at 08:32:29PM +0100, Sam Ravnborg wrote:
> Hi Oleksij
> Thanks for fixing this, but something is not correct.
> I think you switched around the order of comment and compatible.
Ack, i confused my self with comments like:
> > - - edt,etm0700g0dh6
> > - # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > - # Same as ETM0700G0DH6 but with inverted pixel clock.
> > - edt,etm070080bdh6
Do this comments actually make any sense? All of this devices are kind
of similar to each other.
> On Wed, Dec 02, 2020 at 09:18:19AM +0100, Oleksij Rempel wrote:
> > Reorder it alphabetically and remove one double entry.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > .../bindings/display/panel/panel-simple.yaml | 16 +++++++---------
> > 1 file changed, 7 insertions(+), 9 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index edb53ab0d9eb..428b03342fea 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > @@ -106,26 +106,24 @@ properties:
> > # Emerging Display Technology Corp. 3.5" QVGA TFT LCD panel
> > - edt,et035012dm6
> > # Emerging Display Technology Corp. 480x272 TFT Display with capacitive touch
> > + - edt,et057090dhu
> > + # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > - edt,etm043080dh6gp
> > # Emerging Display Technology Corp. 480x272 TFT Display
> > - edt,etm0430g0dh6
> > # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel
> > - - edt,et057090dhu
> > - # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > - - edt,etm070080dh6
> > - # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > # Same display as the ETM0700G0BDH6, but with changed hardware for the
> > # backlight and the touch interface.
> > + - edt,etm070080dh6
> > + # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > - edt,etm070080edh6
> > # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > # Same timings as the ETM0700G0DH6, but with resistive touch.
> > - - edt,etm070080dh6
> > - # Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> > + - edt,etm0700g0dh6
> > + # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > + # Same as ETM0700G0DH6 but with inverted pixel clock.
> > - evervision,vgg804821
> > # Foxlink Group 5" WVGA TFT LCD panel
> > - foxlink,fl500wvr00-a0t
>
> It goes like this
>
> # This is the comment
> - compatible,for-the-comment
>
> I always look at the first entry when I need to check the order.
> Also the comment for evervision,vgg804821 seems to be lost in the above.
ack.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-12-07 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 8:18 [PATCH v6 0/8] mainline Plymovent M2M and BAS board Oleksij Rempel
2020-12-02 8:18 ` [PATCH v6 1/8] dt-bindings: display: simple: fix alphabetical order for EDT compatibles Oleksij Rempel
2020-12-05 19:32 ` Sam Ravnborg
2020-12-07 11:06 ` Oleksij Rempel [this message]
2020-12-02 8:18 ` [PATCH v6 2/8] dt-bindings: display: simple: add EDT compatibles already supported by the driver Oleksij Rempel
2020-12-05 19:35 ` Sam Ravnborg
2020-12-07 11:07 ` Oleksij Rempel
2020-12-02 8:18 ` [PATCH v6 3/8] dt-bindings: display: simple: Add Kyocera tcg070wvlq panel Oleksij Rempel
2020-12-05 19:36 ` Sam Ravnborg
2020-12-07 11:16 ` Oleksij Rempel
2020-12-02 8:18 ` [PATCH v6 4/8] dt-bindings: vendor-prefixes: Add an entry for Plymovent Oleksij Rempel
2020-12-02 8:18 ` [PATCH v6 5/8] dt-bindings: arm: fsl: add Plymovent M2M board Oleksij Rempel
2020-12-02 8:18 ` [PATCH v6 6/8] ARM: dts: " Oleksij Rempel
2020-12-02 8:18 ` [PATCH v6 7/8] dt-bindings: arm: fsl: add Plymovent BAS board Oleksij Rempel
2020-12-02 8:18 ` [PATCH v6 8/8] ARM: dts: " Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207110616.r47utgzdkw3wrply@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).