From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name
Date: Mon, 7 Dec 2020 14:21:40 +0100 [thread overview]
Message-ID: <20201207132140.GA31982@kozik-lap> (raw)
In-Reply-To: <1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com>
On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote:
> Error log:
> sysfs: cannot create duplicate filename '/bus/platform/devices/30000000.bus'
>
> The spba bus name is duplicate with aips bus name.
> Refine spba bus name to fix this issue.
>
> Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index fd669c0f3fe5..30762eb4f0a7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -246,7 +246,7 @@ aips1: bus@30000000 {
> #size-cells = <1>;
> ranges;
>
> - spba: bus@30000000 {
> + spba: spba-bus@30000000 {
The proper node name is "bus" so basically you introduce wrong name to
other problem. Introducing wrong names at least requires a comment.
However the actual problem here is not in node names but in addresses:
aips1: bus@30000000 {
spba: bus@30000000 {
You have to devices with the same unit address. How do you share the
address space?
I think this should be rather fixed.
Best regards,
Krzysztof
> compatible = "fsl,spba-bus", "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-12-07 13:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 6:53 [PATCH] arm64: dts: imx8mn: Fix duplicate node name Shengjiu Wang
2020-12-07 13:21 ` Krzysztof Kozlowski [this message]
2020-12-07 13:32 ` Krzysztof Kozlowski
2020-12-10 23:24 ` Adam Ford
2021-01-07 2:59 ` Shawn Guo
2020-12-08 3:16 S.j. Wang
2020-12-08 8:03 ` Krzysztof Kozlowski
2020-12-08 8:34 ` Krzysztof Kozlowski
2020-12-08 8:44 S.j. Wang
2020-12-08 8:50 ` Krzysztof Kozlowski
2020-12-08 8:57 S.j. Wang
2020-12-08 9:06 ` Krzysztof Kozlowski
2020-12-08 9:22 S.j. Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207132140.GA31982@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).