linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: pwm: pca9685: add staggered-outputs property
@ 2020-11-12 16:39 Clemens Gruber
  2020-12-07 18:50 ` Rob Herring
  0 siblings, 1 reply; 6+ messages in thread
From: Clemens Gruber @ 2020-11-12 16:39 UTC (permalink / raw)
  To: linux-pwm, devicetree
  Cc: Rob Herring, Thierry Reding, u.kleine-koenig, Lee Jones,
	linux-kernel, Clemens Gruber

The pca9685 driver supports a new staggered-outputs property for reduced
current surges and EMI. This adds documentation for the new DT property.

Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
 Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
index f21b55c95738..911bbb65984e 100644
--- a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
@@ -12,6 +12,8 @@ Optional properties:
   - invert (bool): boolean to enable inverted logic
   - open-drain (bool): boolean to configure outputs with open-drain structure;
 		       if omitted use totem-pole structure
+  - staggered-outputs (bool): boolean to enable staggered output ON times to
+			      minimize current surges and EMI
 
 Example:
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: pwm: pca9685: add staggered-outputs property
  2020-11-12 16:39 [PATCH] dt-bindings: pwm: pca9685: add staggered-outputs property Clemens Gruber
@ 2020-12-07 18:50 ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-12-07 18:50 UTC (permalink / raw)
  To: Clemens Gruber
  Cc: linux-pwm, devicetree, Thierry Reding, u.kleine-koenig,
	Lee Jones, linux-kernel

On Thu, Nov 12, 2020 at 05:39:31PM +0100, Clemens Gruber wrote:
> The pca9685 driver supports a new staggered-outputs property for reduced
> current surges and EMI. This adds documentation for the new DT property.
> 
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
>  Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
> index f21b55c95738..911bbb65984e 100644
> --- a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
> @@ -12,6 +12,8 @@ Optional properties:
>    - invert (bool): boolean to enable inverted logic
>    - open-drain (bool): boolean to configure outputs with open-drain structure;
>  		       if omitted use totem-pole structure
> +  - staggered-outputs (bool): boolean to enable staggered output ON times to
> +			      minimize current surges and EMI

Needs a vendor prefix.

>  
>  Example:
>  
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: pwm: pca9685: Add staggered-outputs property
  2020-11-20 12:36   ` Clemens Gruber
@ 2020-11-20 12:48     ` Uwe Kleine-König
  0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2020-11-20 12:48 UTC (permalink / raw)
  To: Clemens Gruber
  Cc: linux-pwm, devicetree, Rob Herring, Thierry Reding, Lee Jones,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Fri, Nov 20, 2020 at 01:36:54PM +0100, Clemens Gruber wrote:
> Hi,
> 
> On Fri, Nov 20, 2020 at 09:21:50AM +0100, Uwe Kleine-König wrote:
> > On Wed, Nov 18, 2020 at 06:45:15PM +0100, Clemens Gruber wrote:
> > > The pca9685 driver supports a new staggered-outputs property for reduced
> > > current surges and EMI. This adds documentation for the new DT property.
> > 
> > Maybe point out the commit that added this support here?
> 
> The pca9685 driver patch was not yet accepted and there will be a v2.
> 
> Should I wait until the support is in Linus' tree and only then send a
> dt-bindings documentation patch, mentioning the commit?

Then I'd say add the dt-bindings patch to the series adding this
support.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: pwm: pca9685: Add staggered-outputs property
  2020-11-20  8:21 ` Uwe Kleine-König
@ 2020-11-20 12:36   ` Clemens Gruber
  2020-11-20 12:48     ` Uwe Kleine-König
  0 siblings, 1 reply; 6+ messages in thread
From: Clemens Gruber @ 2020-11-20 12:36 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: linux-pwm, devicetree, Rob Herring, Thierry Reding, Lee Jones,
	linux-kernel

Hi,

On Fri, Nov 20, 2020 at 09:21:50AM +0100, Uwe Kleine-König wrote:
> On Wed, Nov 18, 2020 at 06:45:15PM +0100, Clemens Gruber wrote:
> > The pca9685 driver supports a new staggered-outputs property for reduced
> > current surges and EMI. This adds documentation for the new DT property.
> 
> Maybe point out the commit that added this support here?

The pca9685 driver patch was not yet accepted and there will be a v2.

Should I wait until the support is in Linus' tree and only then send a
dt-bindings documentation patch, mentioning the commit?

Best regards,
Clemens

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: pwm: pca9685: Add staggered-outputs property
  2020-11-18 17:45 [PATCH] dt-bindings: pwm: pca9685: Add " Clemens Gruber
@ 2020-11-20  8:21 ` Uwe Kleine-König
  2020-11-20 12:36   ` Clemens Gruber
  0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2020-11-20  8:21 UTC (permalink / raw)
  To: Clemens Gruber
  Cc: linux-pwm, devicetree, Rob Herring, Thierry Reding, Lee Jones,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

On Wed, Nov 18, 2020 at 06:45:15PM +0100, Clemens Gruber wrote:
> The pca9685 driver supports a new staggered-outputs property for reduced
> current surges and EMI. This adds documentation for the new DT property.

Maybe point out the commit that added this support here?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] dt-bindings: pwm: pca9685: Add staggered-outputs property
@ 2020-11-18 17:45 Clemens Gruber
  2020-11-20  8:21 ` Uwe Kleine-König
  0 siblings, 1 reply; 6+ messages in thread
From: Clemens Gruber @ 2020-11-18 17:45 UTC (permalink / raw)
  To: linux-pwm, devicetree
  Cc: Rob Herring, Thierry Reding, u.kleine-koenig, Lee Jones,
	linux-kernel, Clemens Gruber

The pca9685 driver supports a new staggered-outputs property for reduced
current surges and EMI. This adds documentation for the new DT property.

Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
 Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
index f21b55c95738..911bbb65984e 100644
--- a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
@@ -12,6 +12,8 @@ Optional properties:
   - invert (bool): boolean to enable inverted logic
   - open-drain (bool): boolean to configure outputs with open-drain structure;
 		       if omitted use totem-pole structure
+  - staggered-outputs (bool): boolean to enable staggered output ON times to
+			      minimize current surges and EMI
 
 Example:
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-12-07 18:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 16:39 [PATCH] dt-bindings: pwm: pca9685: add staggered-outputs property Clemens Gruber
2020-12-07 18:50 ` Rob Herring
2020-11-18 17:45 [PATCH] dt-bindings: pwm: pca9685: Add " Clemens Gruber
2020-11-20  8:21 ` Uwe Kleine-König
2020-11-20 12:36   ` Clemens Gruber
2020-11-20 12:48     ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).