From: "Javier González" <javier@javigon.com>
To: Christoph Hellwig <hch@lst.de>
Cc: SelvaKumar S <selvakuma.s1@samsung.com>,
linux-nvme@lists.infradead.org, kbusch@kernel.org,
axboe@kernel.dk, damien.lemoal@wdc.com, sagi@grimberg.me,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, snitzer@redhat.com, selvajove@gmail.com,
nj.shetty@samsung.com, joshi.k@samsung.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/2] add simple copy support
Date: Mon, 7 Dec 2020 20:14:24 +0100 [thread overview]
Message-ID: <20201207191424.bzwoonfpxknbbqlc@mpHalley> (raw)
In-Reply-To: <20201207141123.GC31159@lst.de>
On 07.12.2020 15:11, Christoph Hellwig wrote:
>So, I'm really worried about:
>
> a) a good use case. GC in f2fs or btrfs seem like good use cases, as
> does accelating dm-kcopyd. I agree with Damien that lifting dm-kcopyd
> to common code would also be really nice. I'm not 100% sure it should
> be a requirement, but it sure would be nice to have
> I don't think just adding an ioctl is enough of a use case for complex
> kernel infrastructure.
We are looking at dm-kcopyd. I would have liked to start with a very
specific use case and build from there, but I see Damien's and Keith's
point of having a default path. I believe we can add this to the next
version.
> b) We had a bunch of different attempts at SCSI XCOPY support form IIRC
> Martin, Bart and Mikulas. I think we need to pull them into this
> discussion, and make sure whatever we do covers the SCSI needs.
Agree. We discussed a lot about the scope and agreed that everything
outside of the specifics of Simple Copy requires the input from the ones
that have worked on XCOPY support in the past.
>
>On Fri, Dec 04, 2020 at 03:16:57PM +0530, SelvaKumar S wrote:
>> This patchset tries to add support for TP4065a ("Simple Copy Command"),
>> v2020.05.04 ("Ratified")
>>
>> The Specification can be found in following link.
>> https://nvmexpress.org/wp-content/uploads/NVM-Express-1.4-Ratified-TPs-1.zip
>>
>> This is an RFC. Looking forward for any feedbacks or other alternate
>> designs for plumbing simple copy to IO stack.
>>
>> Simple copy command is a copy offloading operation and is used to copy
>> multiple contiguous ranges (source_ranges) of LBA's to a single destination
>> LBA within the device reducing traffic between host and device.
>>
>> This implementation accepts destination, no of sources and arrays of
>> source ranges from application and attach it as payload to the bio and
>> submits to the device.
>>
>> Following limits are added to queue limits and are exposed in sysfs
>> to userspace
>> - *max_copy_sectors* limits the sum of all source_range length
>> - *max_copy_nr_ranges* limits the number of source ranges
>> - *max_copy_range_sectors* limit the maximum number of sectors
>> that can constitute a single source range.
>>
>> Changes from v1:
>>
>> 1. Fix memory leak in __blkdev_issue_copy
>> 2. Unmark blk_check_copy inline
>> 3. Fix line break in blk_check_copy_eod
>> 4. Remove p checks and made code more readable
>> 5. Don't use bio_set_op_attrs and remove op and set
>> bi_opf directly
>> 6. Use struct_size to calculate total_size
>> 7. Fix partition remap of copy destination
>> 8. Remove mcl,mssrl,msrc from nvme_ns
>> 9. Initialize copy queue limits to 0 in nvme_config_copy
>> 10. Remove return in QUEUE_FLAG_COPY check
>> 11. Remove unused OCFS
>>
>> SelvaKumar S (2):
>> block: add simple copy support
>> nvme: add simple copy support
>>
>> block/blk-core.c | 94 ++++++++++++++++++++++++++---
>> block/blk-lib.c | 123 ++++++++++++++++++++++++++++++++++++++
>> block/blk-merge.c | 2 +
>> block/blk-settings.c | 11 ++++
>> block/blk-sysfs.c | 23 +++++++
>> block/blk-zoned.c | 1 +
>> block/bounce.c | 1 +
>> block/ioctl.c | 43 +++++++++++++
>> drivers/nvme/host/core.c | 87 +++++++++++++++++++++++++++
>> include/linux/bio.h | 1 +
>> include/linux/blk_types.h | 15 +++++
>> include/linux/blkdev.h | 15 +++++
>> include/linux/nvme.h | 43 ++++++++++++-
>> include/uapi/linux/fs.h | 13 ++++
>> 14 files changed, 461 insertions(+), 11 deletions(-)
>>
>> --
>> 2.25.1
>---end quoted text---
prev parent reply other threads:[~2020-12-07 19:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201204094719epcas5p23b3c41223897de3840f92ae3c229cda5@epcas5p2.samsung.com>
2020-12-04 9:46 ` [RFC PATCH v2 0/2] add simple copy support SelvaKumar S
[not found] ` <CGME20201204094731epcas5p307fe5a0b9360c5057cd48e42c9300053@epcas5p3.samsung.com>
2020-12-04 9:46 ` [RFC PATCH v2 1/2] block: " SelvaKumar S
2020-12-09 4:19 ` [dm-devel] " Martin K. Petersen
2020-12-09 5:17 ` Damien Le Moal
[not found] ` <CGME20201204094747epcas5p121b6eccf78a29ed4cba7c22d6b42d160@epcas5p1.samsung.com>
2020-12-04 9:46 ` [RFC PATCH v2 2/2] nvme: " SelvaKumar S
2020-12-04 11:25 ` [RFC PATCH v2 0/2] " Damien Le Moal
2020-12-04 14:40 ` Keith Busch
2020-12-07 7:46 ` javier.gonz@samsung.com
2020-12-07 8:06 ` Damien Le Moal
2020-12-07 8:16 ` javier.gonz@samsung.com
2020-12-07 9:01 ` Damien Le Moal
2020-12-07 14:11 ` Christoph Hellwig
2020-12-07 14:56 ` Hannes Reinecke
2020-12-07 19:24 ` Javier González
2020-12-08 8:40 ` Johannes Thumshirn
2020-12-08 12:22 ` Javier González
2020-12-08 12:37 ` Johannes Thumshirn
2020-12-08 13:13 ` Javier González
2020-12-08 13:24 ` Johannes Thumshirn
2020-12-09 9:17 ` Javier González
2020-12-15 23:45 ` Pavel Machek
2020-12-07 22:12 ` Douglas Gilbert
2020-12-08 6:44 ` Hannes Reinecke
2020-12-08 12:21 ` Javier González
2020-12-09 3:02 ` Martin K. Petersen
2020-12-07 19:14 ` Javier González [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207191424.bzwoonfpxknbbqlc@mpHalley \
--to=javier@javigon.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=selvajove@gmail.com \
--cc=selvakuma.s1@samsung.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).