From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8CCC4361B for ; Mon, 7 Dec 2020 23:11:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E0CF239FF for ; Mon, 7 Dec 2020 23:11:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727723AbgLGXLg (ORCPT ); Mon, 7 Dec 2020 18:11:36 -0500 Received: from mx2.suse.de ([195.135.220.15]:52790 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgLGXLg (ORCPT ); Mon, 7 Dec 2020 18:11:36 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 26500ABE9; Mon, 7 Dec 2020 23:10:54 +0000 (UTC) Date: Tue, 8 Dec 2020 00:10:49 +0100 From: Borislav Petkov To: "Bae, Chang Seok" Cc: "kvm@vger.kernel.org" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "Liu, Jing2" , "x86@kernel.org" , "luto@kernel.org" , "Shankar, Ravi V" , "Hansen, Dave" , "Brown, Len" Subject: Re: [PATCH v2 01/22] x86/fpu/xstate: Modify area init helper prototypes to access all the possible areas Message-ID: <20201207231049.GE16640@zn.tnic> References: <20201119233257.2939-1-chang.seok.bae@intel.com> <20201119233257.2939-2-chang.seok.bae@intel.com> <20201207171251.GB16640@zn.tnic> <2c4c4340feaf8542fa41e9f4563ecb2b58eef996.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2c4c4340feaf8542fa41e9f4563ecb2b58eef996.camel@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2020 at 11:03:27PM +0000, Bae, Chang Seok wrote: > It was considered to be concise to represent, but it looks to be > unreadable. Not only unreadable but actively confusing - there *is* a "task" pointer all around the kernel which we use for struct task_struct *. > (I suspect this point applicable to PATCH2-4 as well.) Looks like it. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg