[PATCH 1/4] dt-bindings: hwmon: convert TI INA2xx bindings to dt-schema

[PATCH 1/4] dt-bindings: hwmon: convert TI INA2xx bindings to dt-schema

[Krzysztof Kozlowski]

Convert the TI INA2xx bindings to dt-schema.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/hwmon/ina2xx.txt      | 24 --------
 .../devicetree/bindings/hwmon/ti,ina2xx.yaml  | 55 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 56 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/ina2xx.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/ina2xx.txt b/Documentation/devicetree/bindings/hwmon/ina2xx.txt
deleted file mode 100644
index 02af0d94e921..000000000000
--- a/Documentation/devicetree/bindings/hwmon/ina2xx.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-ina2xx properties
-
-Required properties:
-- compatible: Must be one of the following:
-	- "ti,ina209" for ina209
-	- "ti,ina219" for ina219
-	- "ti,ina220" for ina220
-	- "ti,ina226" for ina226
-	- "ti,ina230" for ina230
-	- "ti,ina231" for ina231
-- reg: I2C address
-
-Optional properties:
-
-- shunt-resistor
-	Shunt resistor value in micro-Ohm
-
-Example:
-
-ina220@44 {
-	compatible = "ti,ina220";
-	reg = <0x44>;
-	shunt-resistor = <1000>;
-};
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
new file mode 100644
index 000000000000..6f0443322a36
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/hwmon/ti,ina2xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments INA209 family of power/voltage monitors
+
+maintainers:
+  - Krzysztof Kozlowski <krzk@kernel.org>
+
+description: |
+  The INA209 is a high-side current shunt and power monitor with
+  an I2C interface.
+
+  Datasheets:
+    https://www.ti.com/product/INA209
+
+properties:
+  compatible:
+    enum:
+      - ti,ina209
+      - ti,ina219
+      - ti,ina220
+      - ti,ina226
+      - ti,ina230
+      - ti,ina231
+
+  reg:
+    maxItems: 1
+
+  shunt-resistor:
+    description:
+      Shunt resistor value in micro-Ohm.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        power-sensor@44 {
+            compatible = "ti,ina220";
+            reg = <0x44>;
+            shunt-resistor = <1000>;
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 0818a5b03832..e9ba2e555679 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8669,7 +8669,7 @@ INA209 HARDWARE MONITOR DRIVER
 M:	Guenter Roeck <linux@roeck-us.net>
 L:	linux-hwmon@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/hwmon/ina2xx.txt
+F:	Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
 F:	Documentation/hwmon/ina209.rst
 F:	drivers/hwmon/ina209.c
 
-- 
2.25.1

[PATCH 2/4] dt-bindings: hwmon: convert AD AD741x bindings to dt-schema

[Krzysztof Kozlowski]

Convert the Analog Devices AD741x bindings to dt-schema.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/hwmon/ad741x.txt      | 15 -------
 .../devicetree/bindings/hwmon/adi,ad741x.yaml | 39 +++++++++++++++++++
 2 files changed, 39 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/ad741x.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/ad741x.txt b/Documentation/devicetree/bindings/hwmon/ad741x.txt
deleted file mode 100644
index 9102152c8410..000000000000
--- a/Documentation/devicetree/bindings/hwmon/ad741x.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-* AD7416/AD7417/AD7418 Temperature Sensor Device Tree Bindings
-
-Required properties:
-- compatible: one of
-		"adi,ad7416"
-		"adi,ad7417"
-		"adi,ad7418"
-- reg: I2C address
-
-Example:
-
-hwmon@28 {
-	compatible = "adi,ad7418";
-	reg = <0x28>;
-};
diff --git a/Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml b/Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml
new file mode 100644
index 000000000000..ce7f8ce9da0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/hwmon/adi,ad741x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD7416/AD7417/AD7418 temperature sensors
+
+maintainers:
+  - Krzysztof Kozlowski <krzk@kernel.org>
+
+properties:
+  compatible:
+    enum:
+      - adi,ad7416
+      - adi,ad7417
+      - adi,ad7418
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        temperature-sensor@28 {
+            compatible = "adi,ad7418";
+            reg = <0x28>;
+        };
+    };
-- 
2.25.1

[PATCH 3/4] dt-bindings: hwmon: convert TI ADS7828 bindings to dt-schema

[Krzysztof Kozlowski]

Convert the TI ADS7828 bindings to dt-schema.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/hwmon/ads7828.txt     | 25 --------
 .../devicetree/bindings/hwmon/ti,ads7828.yaml | 57 +++++++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml  |  4 --
 3 files changed, 57 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/ads7828.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/ads7828.txt b/Documentation/devicetree/bindings/hwmon/ads7828.txt
deleted file mode 100644
index fe0cc4ad7ea9..000000000000
--- a/Documentation/devicetree/bindings/hwmon/ads7828.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-ads7828 properties
-
-Required properties:
-- compatible: Should be one of
-	       ti,ads7828
-	       ti,ads7830
-- reg: I2C address
-
-Optional properties:
-
-- ti,differential-input
-  Set to use the device in differential mode.
-- vref-supply
-  The external reference on the device is set to this regulators output. If it
-  does not exists the internal reference will be used and output by the ads78xx
-  on the "external vref" pin.
-
-  Example ADS7828 node:
-
-  ads7828: ads@48 {
-	   comatible = "ti,ads7828";
-	   reg = <0x48>;
-	   vref-supply = <&vref>;
-	   ti,differential-input;
-  };
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml b/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
new file mode 100644
index 000000000000..33ee575bb09d
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/hwmon/ti,ads7828.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments ADS7828/ADS7830 Analog to Digital Converter (ADC)
+
+maintainers:
+  - Krzysztof Kozlowski <krzk@kernel.org>
+
+description: |
+  The ADS7828 is 12-Bit, 8-Channel Sampling Analog to Digital Converter (ADC)
+  with an I2C interface.
+
+  Datasheets:
+    https://www.ti.com/product/ADS7828
+
+properties:
+  compatible:
+    enum:
+      - ti,ads7828
+      - ti,ads7830
+
+  reg:
+    maxItems: 1
+
+  ti,differential-input:
+    description:
+      Set to use the device in differential mode.
+    type: boolean
+
+  vref-supply:
+    description:
+      The regulator to use as an external reference. If it does not exists the
+      internal reference will be used.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        adc@48 {
+            comatible = "ti,ads7828";
+            reg = <0x48>;
+            vref-supply = <&vref>;
+            ti,differential-input;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index ab623ba930d5..1b1fa0424539 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -350,10 +350,6 @@ properties:
           - st,24c256
             # Ambient Light Sensor with SMBUS/Two Wire Serial Interface
           - taos,tsl2550
-            # 8-Channels, 12-bit ADC
-          - ti,ads7828
-            # 8-Channels, 8-bit ADC
-          - ti,ads7830
             # Temperature Monitoring and Fan Control
           - ti,amc6821
             # Temperature sensor with 2-wire interface
-- 
2.25.1

[PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

[Krzysztof Kozlowski]

Convert the Analog Devices ADM1275 bindings to dt-schema.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../bindings/hwmon/adi,adm1275.yaml           | 58 +++++++++++++++++++
 .../devicetree/bindings/hwmon/adm1275.txt     | 25 --------
 Documentation/hwmon/adm1275.rst               |  2 +-
 3 files changed, 59 insertions(+), 26 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
 delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt

diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
new file mode 100644
index 000000000000..2cad28c499dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
+
+maintainers:
+  - Krzysztof Kozlowski <krzk@kernel.org>
+
+description: |
+  The ADM1293 and ADM1294 are high accuracy integrated digital power monitors
+  that offer digital current, voltage, and power monitoring using an on-chip,
+  12-bit analog-to-digital converter (ADC), communicated through a PMBus
+  compliant I2C interface.
+
+  Datasheets:
+    https://www.analog.com/en/products/adm1294.html
+
+properties:
+  compatible:
+    enum:
+      - adi,adm1075
+      - adi,adm1272
+      - adi,adm1275
+      - adi,adm1276
+      - adi,adm1278
+      - adi,adm1293
+      - adi,adm1294
+
+  reg:
+    maxItems: 1
+
+  shunt-resistor-micro-ohms:
+    description:
+      Shunt resistor value in micro-Ohm.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        power-sensor@10 {
+            compatible = "adi,adm1272";
+            reg = <0x10>;
+            shunt-resistor-micro-ohms = <500>;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt
deleted file mode 100644
index 1ecd03f3da4d..000000000000
--- a/Documentation/devicetree/bindings/hwmon/adm1275.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-adm1275 properties
-
-Required properties:
-- compatible: Must be one of the supported compatible strings:
-	- "adi,adm1075" for adm1075
-	- "adi,adm1272" for adm1272
-	- "adi,adm1275" for adm1275
-	- "adi,adm1276" for adm1276
-	- "adi,adm1278" for adm1278
-	- "adi,adm1293" for adm1293
-	- "adi,adm1294" for adm1294
-- reg: I2C address
-
-Optional properties:
-
-- shunt-resistor-micro-ohms
-	Shunt resistor value in micro-Ohm
-
-Example:
-
-adm1272@10 {
-	compatible = "adi,adm1272";
-	reg = <0x10>;
-	shunt-resistor-micro-ohms = <500>;
-};
diff --git a/Documentation/hwmon/adm1275.rst b/Documentation/hwmon/adm1275.rst
index ce6528f90e4a..804590eeabdc 100644
--- a/Documentation/hwmon/adm1275.rst
+++ b/Documentation/hwmon/adm1275.rst
@@ -83,7 +83,7 @@ or current scaling. Reported voltages, currents, and power are raw measurements,
 and will typically have to be scaled.
 
 The shunt value in micro-ohms can be set via device tree at compile-time. Please
-refer to the Documentation/devicetree/bindings/hwmon/adm1275.txt for bindings
+refer to the Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml for bindings
 if the device tree is used.
 
 Platform data support
-- 
2.25.1

Re: [PATCH 1/4] dt-bindings: hwmon: convert TI INA2xx bindings to dt-schema

[Rob Herring]

On Tue, 17 Nov 2020 23:08:04 +0100, Krzysztof Kozlowski wrote:
> Convert the TI INA2xx bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/hwmon/ina2xx.txt      | 24 --------
>  .../devicetree/bindings/hwmon/ti,ina2xx.yaml  | 55 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 56 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ina2xx.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 2/4] dt-bindings: hwmon: convert AD AD741x bindings to dt-schema

[Rob Herring]

On Tue, 17 Nov 2020 23:08:05 +0100, Krzysztof Kozlowski wrote:
> Convert the Analog Devices AD741x bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/hwmon/ad741x.txt      | 15 -------
>  .../devicetree/bindings/hwmon/adi,ad741x.yaml | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ad741x.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 3/4] dt-bindings: hwmon: convert TI ADS7828 bindings to dt-schema

[Rob Herring]

On Tue, 17 Nov 2020 23:08:06 +0100, Krzysztof Kozlowski wrote:
> Convert the TI ADS7828 bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/hwmon/ads7828.txt     | 25 --------
>  .../devicetree/bindings/hwmon/ti,ads7828.yaml | 57 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  4 --
>  3 files changed, 57 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ads7828.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

[Rob Herring]

On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote:
> Convert the Analog Devices ADM1275 bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../bindings/hwmon/adi,adm1275.yaml           | 58 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/adm1275.txt     | 25 --------
>  Documentation/hwmon/adm1275.rst               |  2 +-
>  3 files changed, 59 insertions(+), 26 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> new file mode 100644
> index 000000000000..2cad28c499dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +description: |
> +  The ADM1293 and ADM1294 are high accuracy integrated digital power monitors
> +  that offer digital current, voltage, and power monitoring using an on-chip,
> +  12-bit analog-to-digital converter (ADC), communicated through a PMBus
> +  compliant I2C interface.
> +
> +  Datasheets:
> +    https://www.analog.com/en/products/adm1294.html
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,adm1075
> +      - adi,adm1272
> +      - adi,adm1275
> +      - adi,adm1276
> +      - adi,adm1278
> +      - adi,adm1293
> +      - adi,adm1294
> +
> +  reg:
> +    maxItems: 1
> +
> +  shunt-resistor-micro-ohms:
> +    description:
> +      Shunt resistor value in micro-Ohm.
> +    $ref: /schemas/types.yaml#/definitions/uint32

Don't need a type if you have units. With that dropped,

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/4] dt-bindings: hwmon: convert TI INA2xx bindings to dt-schema

[Guenter Roeck]

On Tue, Nov 17, 2020 at 11:08:04PM +0100, Krzysztof Kozlowski wrote:
> Convert the TI INA2xx bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ina2xx.txt      | 24 --------
>  .../devicetree/bindings/hwmon/ti,ina2xx.yaml  | 55 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 56 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ina2xx.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ina2xx.txt b/Documentation/devicetree/bindings/hwmon/ina2xx.txt
> deleted file mode 100644
> index 02af0d94e921..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ina2xx.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -ina2xx properties
> -
> -Required properties:
> -- compatible: Must be one of the following:
> -	- "ti,ina209" for ina209
> -	- "ti,ina219" for ina219
> -	- "ti,ina220" for ina220
> -	- "ti,ina226" for ina226
> -	- "ti,ina230" for ina230
> -	- "ti,ina231" for ina231
> -- reg: I2C address
> -
> -Optional properties:
> -
> -- shunt-resistor
> -	Shunt resistor value in micro-Ohm
> -
> -Example:
> -
> -ina220@44 {
> -	compatible = "ti,ina220";
> -	reg = <0x44>;
> -	shunt-resistor = <1000>;
> -};
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> new file mode 100644
> index 000000000000..6f0443322a36
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/ti,ina2xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments INA209 family of power/voltage monitors
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +description: |
> +  The INA209 is a high-side current shunt and power monitor with
> +  an I2C interface.
> +
> +  Datasheets:
> +    https://www.ti.com/product/INA209
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ina209
> +      - ti,ina219
> +      - ti,ina220
> +      - ti,ina226
> +      - ti,ina230
> +      - ti,ina231
> +
> +  reg:
> +    maxItems: 1
> +
> +  shunt-resistor:
> +    description:
> +      Shunt resistor value in micro-Ohm.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        power-sensor@44 {
> +            compatible = "ti,ina220";
> +            reg = <0x44>;
> +            shunt-resistor = <1000>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0818a5b03832..e9ba2e555679 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8669,7 +8669,7 @@ INA209 HARDWARE MONITOR DRIVER
>  M:	Guenter Roeck <linux@roeck-us.net>
>  L:	linux-hwmon@vger.kernel.org
>  S:	Maintained
> -F:	Documentation/devicetree/bindings/hwmon/ina2xx.txt
> +F:	Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>  F:	Documentation/hwmon/ina209.rst
>  F:	drivers/hwmon/ina209.c
>  

Re: [PATCH 2/4] dt-bindings: hwmon: convert AD AD741x bindings to dt-schema

[Guenter Roeck]

On Tue, Nov 17, 2020 at 11:08:05PM +0100, Krzysztof Kozlowski wrote:
> Convert the Analog Devices AD741x bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ad741x.txt      | 15 -------
>  .../devicetree/bindings/hwmon/adi,ad741x.yaml | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ad741x.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ad741x.txt b/Documentation/devicetree/bindings/hwmon/ad741x.txt
> deleted file mode 100644
> index 9102152c8410..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ad741x.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -* AD7416/AD7417/AD7418 Temperature Sensor Device Tree Bindings
> -
> -Required properties:
> -- compatible: one of
> -		"adi,ad7416"
> -		"adi,ad7417"
> -		"adi,ad7418"
> -- reg: I2C address
> -
> -Example:
> -
> -hwmon@28 {
> -	compatible = "adi,ad7418";
> -	reg = <0x28>;
> -};
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml b/Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml
> new file mode 100644
> index 000000000000..ce7f8ce9da0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,ad741x.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/adi,ad741x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7416/AD7417/AD7418 temperature sensors
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,ad7416
> +      - adi,ad7417
> +      - adi,ad7418
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        temperature-sensor@28 {
> +            compatible = "adi,ad7418";
> +            reg = <0x28>;
> +        };
> +    };

Re: [PATCH 3/4] dt-bindings: hwmon: convert TI ADS7828 bindings to dt-schema

[Guenter Roeck]

On Tue, Nov 17, 2020 at 11:08:06PM +0100, Krzysztof Kozlowski wrote:
> Convert the TI ADS7828 bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ads7828.txt     | 25 --------
>  .../devicetree/bindings/hwmon/ti,ads7828.yaml | 57 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  4 --
>  3 files changed, 57 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ads7828.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ads7828.txt b/Documentation/devicetree/bindings/hwmon/ads7828.txt
> deleted file mode 100644
> index fe0cc4ad7ea9..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ads7828.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -ads7828 properties
> -
> -Required properties:
> -- compatible: Should be one of
> -	       ti,ads7828
> -	       ti,ads7830
> -- reg: I2C address
> -
> -Optional properties:
> -
> -- ti,differential-input
> -  Set to use the device in differential mode.
> -- vref-supply
> -  The external reference on the device is set to this regulators output. If it
> -  does not exists the internal reference will be used and output by the ads78xx
> -  on the "external vref" pin.
> -
> -  Example ADS7828 node:
> -
> -  ads7828: ads@48 {
> -	   comatible = "ti,ads7828";
> -	   reg = <0x48>;
> -	   vref-supply = <&vref>;
> -	   ti,differential-input;
> -  };
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml b/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
> new file mode 100644
> index 000000000000..33ee575bb09d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/ti,ads7828.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADS7828/ADS7830 Analog to Digital Converter (ADC)
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +description: |
> +  The ADS7828 is 12-Bit, 8-Channel Sampling Analog to Digital Converter (ADC)
> +  with an I2C interface.
> +
> +  Datasheets:
> +    https://www.ti.com/product/ADS7828
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ads7828
> +      - ti,ads7830
> +
> +  reg:
> +    maxItems: 1
> +
> +  ti,differential-input:
> +    description:
> +      Set to use the device in differential mode.
> +    type: boolean
> +
> +  vref-supply:
> +    description:
> +      The regulator to use as an external reference. If it does not exists the
> +      internal reference will be used.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@48 {
> +            comatible = "ti,ads7828";
> +            reg = <0x48>;
> +            vref-supply = <&vref>;
> +            ti,differential-input;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ab623ba930d5..1b1fa0424539 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -350,10 +350,6 @@ properties:
>            - st,24c256
>              # Ambient Light Sensor with SMBUS/Two Wire Serial Interface
>            - taos,tsl2550
> -            # 8-Channels, 12-bit ADC
> -          - ti,ads7828
> -            # 8-Channels, 8-bit ADC
> -          - ti,ads7830
>              # Temperature Monitoring and Fan Control
>            - ti,amc6821
>              # Temperature sensor with 2-wire interface

Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

[Guenter Roeck]

On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote:
> On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote:
> > Convert the Analog Devices ADM1275 bindings to dt-schema.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  .../bindings/hwmon/adi,adm1275.yaml           | 58 +++++++++++++++++++
> >  .../devicetree/bindings/hwmon/adm1275.txt     | 25 --------
> >  Documentation/hwmon/adm1275.rst               |  2 +-
> >  3 files changed, 59 insertions(+), 26 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > new file mode 100644
> > index 000000000000..2cad28c499dc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > @@ -0,0 +1,58 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
> > +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
> > +
> > +maintainers:
> > +  - Krzysztof Kozlowski <krzk@kernel.org>
> > +
> > +description: |
> > +  The ADM1293 and ADM1294 are high accuracy integrated digital power monitors
> > +  that offer digital current, voltage, and power monitoring using an on-chip,
> > +  12-bit analog-to-digital converter (ADC), communicated through a PMBus
> > +  compliant I2C interface.
> > +
> > +  Datasheets:
> > +    https://www.analog.com/en/products/adm1294.html
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,adm1075
> > +      - adi,adm1272
> > +      - adi,adm1275
> > +      - adi,adm1276
> > +      - adi,adm1278
> > +      - adi,adm1293
> > +      - adi,adm1294
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  shunt-resistor-micro-ohms:
> > +    description:
> > +      Shunt resistor value in micro-Ohm.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> Don't need a type if you have units. With that dropped,
> 

Sorry, I am not familiar with the terminology. Does that refer to
the '$ref' line ?

Thanks,
Guenter

Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

[Krzysztof Kozlowski]

On Mon, Dec 07, 2020 at 04:19:16PM -0800, Guenter Roeck wrote:
> On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote:
> > On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote:
> > > Convert the Analog Devices ADM1275 bindings to dt-schema.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > >  .../bindings/hwmon/adi,adm1275.yaml           | 58 +++++++++++++++++++
> > >  .../devicetree/bindings/hwmon/adm1275.txt     | 25 --------
> > >  Documentation/hwmon/adm1275.rst               |  2 +-
> > >  3 files changed, 59 insertions(+), 26 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > > new file mode 100644
> > > index 000000000000..2cad28c499dc
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > > @@ -0,0 +1,58 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +
> > > +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
> > > +
> > > +maintainers:
> > > +  - Krzysztof Kozlowski <krzk@kernel.org>
> > > +
> > > +description: |
> > > +  The ADM1293 and ADM1294 are high accuracy integrated digital power monitors
> > > +  that offer digital current, voltage, and power monitoring using an on-chip,
> > > +  12-bit analog-to-digital converter (ADC), communicated through a PMBus
> > > +  compliant I2C interface.
> > > +
> > > +  Datasheets:
> > > +    https://www.analog.com/en/products/adm1294.html
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - adi,adm1075
> > > +      - adi,adm1272
> > > +      - adi,adm1275
> > > +      - adi,adm1276
> > > +      - adi,adm1278
> > > +      - adi,adm1293
> > > +      - adi,adm1294
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  shunt-resistor-micro-ohms:
> > > +    description:
> > > +      Shunt resistor value in micro-Ohm.
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > 
> > Don't need a type if you have units. With that dropped,
> > 
> 
> Sorry, I am not familiar with the terminology. Does that refer to
> the '$ref' line ?

Yes, it's the $ref line which can be safely removed. The core dt-schema
applies such $ref if the property name ends with '-micro-ohms'.

Best regards,
Krzysztof

Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

[Guenter Roeck]

On 12/8/20 12:13 AM, Krzysztof Kozlowski wrote:
> On Mon, Dec 07, 2020 at 04:19:16PM -0800, Guenter Roeck wrote:
>> On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote:
>>> On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote:
>>>> Convert the Analog Devices ADM1275 bindings to dt-schema.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>>> ---
>>>>  .../bindings/hwmon/adi,adm1275.yaml           | 58 +++++++++++++++++++
>>>>  .../devicetree/bindings/hwmon/adm1275.txt     | 25 --------
>>>>  Documentation/hwmon/adm1275.rst               |  2 +-
>>>>  3 files changed, 59 insertions(+), 26 deletions(-)
>>>>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>>>>  delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>>>> new file mode 100644
>>>> index 000000000000..2cad28c499dc
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>>>> @@ -0,0 +1,58 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +
>>>> +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
>>>> +
>>>> +maintainers:
>>>> +  - Krzysztof Kozlowski <krzk@kernel.org>
>>>> +
>>>> +description: |
>>>> +  The ADM1293 and ADM1294 are high accuracy integrated digital power monitors
>>>> +  that offer digital current, voltage, and power monitoring using an on-chip,
>>>> +  12-bit analog-to-digital converter (ADC), communicated through a PMBus
>>>> +  compliant I2C interface.
>>>> +
>>>> +  Datasheets:
>>>> +    https://www.analog.com/en/products/adm1294.html
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    enum:
>>>> +      - adi,adm1075
>>>> +      - adi,adm1272
>>>> +      - adi,adm1275
>>>> +      - adi,adm1276
>>>> +      - adi,adm1278
>>>> +      - adi,adm1293
>>>> +      - adi,adm1294
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  shunt-resistor-micro-ohms:
>>>> +    description:
>>>> +      Shunt resistor value in micro-Ohm.
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>
>>> Don't need a type if you have units. With that dropped,
>>>
>>
>> Sorry, I am not familiar with the terminology. Does that refer to
>> the '$ref' line ?
> 
> Yes, it's the $ref line which can be safely removed. The core dt-schema
> applies such $ref if the property name ends with '-micro-ohms'.
> 

Thanks a lot for the information. Ill apply the patch with this line removed.

Thanks,
Guenter