From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C047FC4361B for ; Tue, 8 Dec 2020 00:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 907A123A04 for ; Tue, 8 Dec 2020 00:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgLHArs (ORCPT ); Mon, 7 Dec 2020 19:47:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728824AbgLHArr (ORCPT ); Mon, 7 Dec 2020 19:47:47 -0500 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05D16C061749; Mon, 7 Dec 2020 16:47:03 -0800 (PST) Received: by mail-qt1-x842.google.com with SMTP id c14so1308207qtn.0; Mon, 07 Dec 2020 16:47:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VZHUufd0g6UdJFDVTYdblkgbgMRwbf0Y/fHI7mLRtWU=; b=l8tTsbTg21o1/hkJDil01QyPt1S+hNNQArxmXVMWZl+14KG3cwUPD9yhA9zz5er/OS WYmStLyhnHG81FxqOu7c5y430buEHIvhm1Kow/NQKRBzNLmEZELihteVRg5vdXuLfAHG rCoL22aDgnYFYdg61Z5cuWrNOH2SbjzbnuSM9xLI1c/BWw55NcLnaGoD4ziICgb+XXXK ZeF6QVt5WjFDXfuParnupBwgMVJIt4Nk49/ME1JGFmKbptXtgpSroyIdGE0tbGMqLfhi B0JM0p8wI/gGSE0p8C1IQpscG2TL91p7V58n7vS9habhu8GuNnQ8wlQktv+vR8fmUA6f 4RyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VZHUufd0g6UdJFDVTYdblkgbgMRwbf0Y/fHI7mLRtWU=; b=SRGbrW0SIzqsr+RLBdHk1qe54LmJtlZUTuSdDq32ZhX/qSt382FeH7cHaDOVR2ULIO +9QC52fS5tcfJGXO5NuaRAssTgmN9qGBaL/F1fVw64O0FWphC68EkgkZ2yFW3wGnYyMh 5k7o4p/3DTyZ9oOUbPrnr4iEjXbySPqI+v29gBCxAonPmfLKv5AoK/bA8qh8oprUZEBj 3jhaYSjR6qdL8euMWpQwY47CDVOURDoOsyt6GcpBBJDIR61c5zMWQNVsTp1e2zG+tFLC RA+q7LewQCZuoOmb1oSgW4HC2NBUP7uev7QO0MNd85qT6c23uzAwUiZs0lDr9fS1SnwA x8Hw== X-Gm-Message-State: AOAM532JHV4ENlJKXhyq/SwsONxn00CgplUokizYTLOmhWKGZ5fHQcAO L9/NG0yViZHvZ9yBSoq6LyM= X-Google-Smtp-Source: ABdhPJxkqh2BZJT/hzS1hsNzGm89wAIBgMDItnp0jBYXVFcXuYuBQBr+FGcdnMvIwDpLuGTDZMUazw== X-Received: by 2002:ac8:51d8:: with SMTP id d24mr14423965qtn.73.1607388422238; Mon, 07 Dec 2020 16:47:02 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id x28sm11544785qtv.8.2020.12.07.16.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 16:47:01 -0800 (PST) Date: Mon, 7 Dec 2020 17:46:59 -0700 From: Nathan Chancellor To: Sami Tolvanen Cc: Nick Desaulniers , Will Deacon , Masahiro Yamada , Steven Rostedt , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , linux-kbuild , LKML , PCI , Jian Cai , Kristof Beyls Subject: Re: [PATCH v8 00/16] Add support for Clang LTO Message-ID: <20201208004659.GA587492@ubuntu-m3-large-x86> References: <20201201213707.541432-1-samitolvanen@google.com> <20201203112622.GA31188@willie-the-truck> <20201203182252.GA32011@willie-the-truck> <20201206065028.GA2819096@ubuntu-m3-large-x86> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 06, 2020 at 12:09:31PM -0800, Sami Tolvanen wrote: > Sure, looks good to me. However, I think we should also test for > LLVM=1 to avoid possible further issues with mismatched toolchains > instead of only checking for llvm-nm and llvm-ar. It might still be worth testing for $(AR) and $(NM) because in theory, a user could say 'make AR=ar LLVM=1'. Highly unlikely I suppose but worth considering. Cheers, Nathan