From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: bhelgaas@google.com
Cc: hkallweit1@gmail.com, Kai-Heng Feng <kai.heng.feng@canonical.com>,
"Saheed O. Bolarinwa" <refactormyself@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Xiongfeng Wang <wangxiongfeng2@huawei.com>,
linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/2] PCI/ASPM: Use capability to override ASPM via sysfs
Date: Tue, 8 Dec 2020 16:25:34 +0800 [thread overview]
Message-ID: <20201208082534.2460215-2-kai.heng.feng@canonical.com> (raw)
In-Reply-To: <20201208082534.2460215-1-kai.heng.feng@canonical.com>
If we are to use sysfs to change ASPM settings, we may want to override
the default ASPM policy.
So use ASPM capability, instead of default policy, to be able to use all
possible ASPM states.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/pci/pcie/aspm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 2ea9fddadfad..326da7bbc84d 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -1239,8 +1239,7 @@ static ssize_t aspm_attr_store_common(struct device *dev,
link->aspm_disable |= state;
}
-
- pcie_config_aspm_link(link, policy_to_aspm_state(link));
+ pcie_config_aspm_link(link, link->aspm_capable);
mutex_unlock(&aspm_lock);
up_read(&pci_bus_sem);
--
2.29.2
next prev parent reply other threads:[~2020-12-08 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 8:25 [PATCH 1/2] PCI/ASPM: Store disabled ASPM states Kai-Heng Feng
2020-12-08 8:25 ` Kai-Heng Feng [this message]
2020-12-08 17:18 ` [PATCH 2/2] PCI/ASPM: Use capability to override ASPM via sysfs Heiner Kallweit
2020-12-09 17:50 ` Kai-Heng Feng
2020-12-08 17:11 ` [PATCH 1/2] PCI/ASPM: Store disabled ASPM states Heiner Kallweit
2020-12-09 17:34 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208082534.2460215-2-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=refactormyself@gmail.com \
--cc=wangxiongfeng2@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).