From: Christoph Hellwig <hch@infradead.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: Remove dead termiox code
Date: Tue, 8 Dec 2020 11:13:12 +0000 [thread overview]
Message-ID: <20201208111312.GA27425@infradead.org> (raw)
In-Reply-To: <93834a92-b342-aaee-c400-2883d5df0cdc@kernel.org>
On Fri, Dec 04, 2020 at 09:20:39AM +0100, Jiri Slaby wrote:
> > > > Delete this dead code; but leave the definition of struct termiox in the
> > > > UAPI headers intact.
> > >
> > > I am thinking -- can/should we mark the structure as deprecated so that
> > > userspace stops using it eventually?
> >
> > If it doesn't do anything, how can userspace even use it today? :)
>
> Well, right. I am in favor to remove it, BUT: what if someone tries that
> ioctl and bails out if EINVAL is returned. I mean: if they define a local
> var of that struct type and pass it to the ioctl, we would break the build
> by removing the struct completely. Even if the code didn't do anything
> useful, it still could be built. So is this very potential breakage OK?
Um, we do guarantee a stable ABI. We have never guaranteed that all old
crappy code will continue to compile, although we avoid gratious
breakage. And assuming there ever was code using termiox (which I'm not
sure about to start with) it will surely have some form of feature
check, and I think we are better off with that feature check not
detecting the presence as that would be completely pointless.
Or in short: by keeping the uapi definition we do userspace software a
disfavor.
next prev parent reply other threads:[~2020-12-08 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 2:03 [PATCH] tty: Remove dead termiox code Jann Horn
2020-12-03 18:43 ` Greg Kroah-Hartman
2020-12-04 7:22 ` Jiri Slaby
2020-12-04 8:17 ` Greg Kroah-Hartman
2020-12-04 8:20 ` Jiri Slaby
2020-12-04 8:36 ` Greg Kroah-Hartman
2020-12-04 8:51 ` Jiri Slaby
2020-12-04 9:10 ` Greg Kroah-Hartman
2020-12-07 10:19 ` Adam Borowski
2020-12-07 13:57 ` Greg Kroah-Hartman
2020-12-08 11:13 ` Christoph Hellwig [this message]
2020-12-08 11:23 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208111312.GA27425@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).