From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087D8C4361B for ; Tue, 8 Dec 2020 12:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCC6423A52 for ; Tue, 8 Dec 2020 12:24:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729547AbgLHMYI (ORCPT ); Tue, 8 Dec 2020 07:24:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729388AbgLHMYH (ORCPT ); Tue, 8 Dec 2020 07:24:07 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48261C061794; Tue, 8 Dec 2020 04:23:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UNxXJNXqQX33pzDKLkLUQwPsiKXBBcwJYZRxFVbPnps=; b=O/IQVntJZbkpB69wJ39eyVCtkh JJARkVk4MvbcQkuYX8rGTsvb5Rnge7YOct0s4PSHnT8xJQQ3Z3HO/eEacoUd8ngR4xNlDzEYf0XEA Y1fuio0PpOhmsPUHvCz0tsnCrzYCRFQ7/NXClDyiron7GGQy5BKz9xb48TpFc969jU7mPY48b8tr9 IiEkGx4OcDfrwzT/IxJum56BPO5ug6IBVYKBxLTiz+zeZm2T9WaKxY1B2hLi/WIdV2LHpG0tebefB CzhZR/bwnsyYY+guh6tWs2ghinTb9ieumMIQFRnzfmwVXsrNClVsLUjiC/UUyMCoFu7tsdcYRybJ4 RFGAsSLQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmc1U-0002xv-Sc; Tue, 08 Dec 2020 12:23:16 +0000 Date: Tue, 8 Dec 2020 12:23:16 +0000 From: Matthew Wilcox To: ira.weiny@intel.com Cc: Thomas Gleixner , Andrew Morton , Dave Hansen , Christoph Hellwig , Dan Williams , Al Viro , Eric Biggers , Joonas Lahtinen , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core Message-ID: <20201208122316.GH7338@casper.infradead.org> References: <20201207225703.2033611-1-ira.weiny@intel.com> <20201207225703.2033611-3-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207225703.2033611-3-ira.weiny@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2020 at 02:57:03PM -0800, ira.weiny@intel.com wrote: > Placing these functions in 'highmem.h' is suboptimal especially with the > changes being proposed in the functionality of kmap. From a caller > perspective including/using 'highmem.h' implies that the functions > defined in that header are only required when highmem is in use which is > increasingly not the case with modern processors. Some headers like > mm.h or string.h seem ok but don't really portray the functionality > well. 'pagemap.h', on the other hand, makes sense and is already > included in many of the places we want to convert. pagemap.h is for the page cache. It's not for "random page functionality". Yes, I know it's badly named. No, I don't want to rename it. These helpers should go in highmem.h along with zero_user().