From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E02C4361B for ; Tue, 8 Dec 2020 13:14:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30E7923AA8 for ; Tue, 8 Dec 2020 13:14:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728287AbgLHNOW (ORCPT ); Tue, 8 Dec 2020 08:14:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgLHNOW (ORCPT ); Tue, 8 Dec 2020 08:14:22 -0500 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B139C061793 for ; Tue, 8 Dec 2020 05:13:36 -0800 (PST) Received: by mail-ed1-x542.google.com with SMTP id h16so6210096edt.7 for ; Tue, 08 Dec 2020 05:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=javigon-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4H0t76z3d9Gm8+rnlsRXMej2iqZW90QwJGGNcAOGfNQ=; b=JAzSmLxxgeFhhHjbJmv4czCcTVN37dDptyYJOl2vbRL3Kg0Eda4yv79sD8kMfO0W9S 755X4aNtjn8/PDQ714OSMQWmUEpi3o2kj48M0Pau3F+eON22OEuSEQSgv+ssnT/+K6eC 5aj7Lne6pqgTUjZ7ZbBS/DFNldcQ4aFV/HcS5eZwxiOlFpf0/ZDx99a28W3UW/PBlcL4 +BweyvMen5WEQ6Zi/Y52ky0t+B/lP2/Sm1hV4x59IV2xMORTLdcltLMa+0e7nQqg6sg6 wcabTKaDzHQcnkkWBuazi1q1wH8oXbHxXekHtbytDm2B0X1FmRK+IbhrMf17qT6GBY5i 8rvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4H0t76z3d9Gm8+rnlsRXMej2iqZW90QwJGGNcAOGfNQ=; b=m8Z/TLVEwfG1Df6sEN4Y6/y8bJAlKSfOq5TG3zSCM1QRbZ1E59Tm+ZlwJJUn442AbG mMtHx7+2FpzopA5JoA/cmCpwaJV6yBpPW1hbsx+e0BA55DtA7Uhsu6kS52AruFx8/xMp /uP3Ynq5akyEP5WD6QyFa8lnFc5fjc7qbVbx6eSJ6KUE7x40xBQ1nVTboRHVyhbCnqTe N2xdTs4NEBCdD5KmicbQE28WcQoz7e2leGf2+hnDUJos7XrxRcRKQFqhgEsKxl00wtk5 XVWHReu8Rpvafk1J0I+2pPVeXN/TihFDwcuaLfUeKzzplNQcHbaq9vBpYMwNguYf1XHd UkeA== X-Gm-Message-State: AOAM532DxQ0YVZpNzYelayD9q4G3uy5Pz3y+Tmnikitpjm9VTK8JZRX2 F3RtZmlzE7+KbaQOkOyRLwsalg== X-Google-Smtp-Source: ABdhPJxzR3lshkmLf680nwJwf3iSrf8fXTQ9WUttlW08OFCU+GJEW3f7mGgCqOCWWXeIGq2QqC1DUQ== X-Received: by 2002:aa7:dac5:: with SMTP id x5mr25105016eds.198.1607433214946; Tue, 08 Dec 2020 05:13:34 -0800 (PST) Received: from localhost (5.186.124.214.cgn.fibianet.dk. [5.186.124.214]) by smtp.gmail.com with ESMTPSA id u5sm16894960edp.5.2020.12.08.05.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 05:13:34 -0800 (PST) Date: Tue, 8 Dec 2020 14:13:33 +0100 From: Javier =?utf-8?B?R29uesOhbGV6?= To: Johannes Thumshirn Cc: Hannes Reinecke , Christoph Hellwig , SelvaKumar S , "linux-nvme@lists.infradead.org" , "kbusch@kernel.org" , "axboe@kernel.dk" , Damien Le Moal , "sagi@grimberg.me" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dm-devel@redhat.com" , "snitzer@redhat.com" , "selvajove@gmail.com" , "nj.shetty@samsung.com" , "joshi.k@samsung.com" , "Martin K. Petersen" , Bart Van Assche , Mikulas Patocka , "linux-scsi@vger.kernel.org" Subject: Re: [RFC PATCH v2 0/2] add simple copy support Message-ID: <20201208131333.xoxincxcnh7iz33z@mpHalley> References: <20201204094659.12732-1-selvakuma.s1@samsung.com> <20201207141123.GC31159@lst.de> <01fe46ac-16a5-d4db-f23d-07a03d3935f3@suse.de> <20201207192453.vc6clbdhz73hzs7l@mpHalley> <20201208122248.utv7pqthmmn6uwv6@mpHalley> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.12.2020 12:37, Johannes Thumshirn wrote: >On 08/12/2020 13:22, Javier González wrote: >> Good idea. Are you thinking of a sysfs entry to select the backend? > >Not sure on this one, initially I thought of a sysfs file, but then >how would you do it. One "global" sysfs entry is probably a bad idea. >Having one per block device to select native vs emulation maybe? And >a good way to benchmark. I was thinking a per block device to target the use case where a certain implementation / workload is better one way or the other. > >The other idea would be a benchmark loop on boot like the raid library >does. > >Then on the other hand, there might be workloads that run faster with >the emulation and some that run faster with the hardware acceleration. > >I think these points are the reason the last attempts got stuck. Yes. I believe that any benchmark we run would be biased in a certain way. If we can move forward with a sysfs entry and default to legacy path, we would not alter current behavior and enable NVMe copy offload (for now) for those that want to use it. We can then build on top of it. Does this sound like a reasonable approach?