Hi Qing, Thank you for the patch! Yet something to improve: [auto build test ERROR on spi/for-next] [also build test ERROR on robh/for-next linus/master v5.10-rc7 next-20201208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Qing-Zhang/spi-LS7A-Add-Loongson-LS7A-SPI-controller-driver-support/20201208-154822 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next config: c6x-allyesconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6b2c3d42e1460dd3472a2c74d6a6c46d8693ce79 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qing-Zhang/spi-LS7A-Add-Loongson-LS7A-SPI-controller-driver-support/20201208-154822 git checkout 6b2c3d42e1460dd3472a2c74d6a6c46d8693ce79 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): drivers/spi/spi-ls7a.c: In function 'ls7a_spi_write_read': drivers/spi/spi-ls7a.c:162:19: warning: variable 'ls7a_spi' set but not used [-Wunused-but-set-variable] 162 | struct ls7a_spi *ls7a_spi; | ^~~~~~~~ drivers/spi/spi-ls7a.c: At top level: >> drivers/spi/spi-ls7a.c:320:1: warning: data definition has no type or storage class 320 | module_pci_driver(ls7a_spi_pci_driver); | ^~~~~~~~~~~~~~~~~ >> drivers/spi/spi-ls7a.c:320:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] >> drivers/spi/spi-ls7a.c:320:1: warning: parameter names (without types) in function declaration drivers/spi/spi-ls7a.c:313:26: warning: 'ls7a_spi_pci_driver' defined but not used [-Wunused-variable] 313 | static struct pci_driver ls7a_spi_pci_driver = { | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +320 drivers/spi/spi-ls7a.c 319 > 320 module_pci_driver(ls7a_spi_pci_driver); 321 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org