From: Ivan Mikhaylov <i.mikhaylov@yadro.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: Ivan Mikhaylov <i.mikhaylov@yadro.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] Add LED mode behavior/select properties and handle
Date: Wed, 9 Dec 2020 17:04:59 +0300 [thread overview]
Message-ID: <20201209140501.17415-1-i.mikhaylov@yadro.com> (raw)
In KSZ9131 PHY it is possible to control LEDs blink behavior via
LED mode behavior and select registers. Add DTS properties plus handles
of them inside micrel PHY driver.
I've some concerns about passing raw register values into LED mode
select and behavior. It can be passed via array like in microchip
driver(Documentation/devicetree/bindings/net/microchip,lan78xx.txt).
There is the problem in this particular driver - there is a lot of other PHYs
and led mode behavior/select states may intersect, that's the reason why
I did it this way. Is there any good ways to make it look more properly?
Ivan Mikhaylov (2):
net: phy: micrel: add LED control on KSZ9131
dt-bindings: net: phy: micrel: add LED mode behavior and select
properties
.../devicetree/bindings/net/micrel.txt | 7 ++
drivers/net/phy/micrel.c | 69 ++++++++++++++++++-
2 files changed, 75 insertions(+), 1 deletion(-)
--
2.21.1
next reply other threads:[~2020-12-09 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 14:04 Ivan Mikhaylov [this message]
2020-12-09 14:05 ` [PATCH 1/2] net: phy: micrel: add LED control on KSZ9131 Ivan Mikhaylov
2020-12-09 14:05 ` [PATCH 2/2] dt-bindings: net: phy: micrel: add LED mode behavior and select properties Ivan Mikhaylov
2020-12-09 23:05 ` [PATCH 0/2] Add LED mode behavior/select properties and handle Andrew Lunn
2020-12-16 22:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209140501.17415-1-i.mikhaylov@yadro.com \
--to=i.mikhaylov@yadro.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).