From: Rob Herring <robh@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Gene Chen <gene.chen.richtek@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com, benjamin.chao@mediatek.com
Subject: Re: [PATCH v11 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
Date: Wed, 9 Dec 2020 13:53:36 -0600 [thread overview]
Message-ID: <20201209195336.GB826766@robh.at.kernel.org> (raw)
In-Reply-To: <87a4f0b9-1450-cd9f-70ea-dd5b408893f3@gmail.com>
On Thu, Dec 03, 2020 at 09:06:42PM +0100, Jacek Anaszewski wrote:
> Hi Pavel,
>
> On 12/3/20 12:40 PM, Pavel Machek wrote:
> > Hi!
> >
> > > > > +++ b/include/dt-bindings/leds/common.h
> > > > > @@ -78,6 +78,7 @@
> > > > > #define LED_FUNCTION_INDICATOR "indicator"
> > > > > #define LED_FUNCTION_LAN "lan"
> > > > > #define LED_FUNCTION_MAIL "mail"
> > > > > +#define LED_FUNCTION_MOONLIGHT "moonlight"
> > > >
> > > > There's "torch" function that should be used for this. I guess comment
> > > > should be added with explanation what exactly that is and how should
> > > > the LED be named.
> > > >
> > >
> > > According to mail, 11/25 "Re: [PATCH v7 2/5] dt-bindings: leds: Add
> > > LED_COLOR_ID_MOONLIGHT definitions",
> > > The Moonlight LED is LED which maximum current more than torch, but
> > > less than flash. Such as front camera fill light.
> > > I think our channel is moonlight, not torch.
> > > I will add this description to comment.
> > > We can't exactly define moonlight current level, because every vendor
> > > has their own specification.
> >
> > So... what is the timelimit on moonlight?
> >
> > But if it is used for camera illumination, I believe it should be
> > simply called flash.
>
> Let's keep FLASH reserved for LED flash class devices.
> This device has already two other flash iouts.
>
> Also iouts amperage gives clue that they have three different
> functions.
Perhaps there should just be a table of currents and max times rather
than trying to continually expand this while tied to function.
One could simply want an LED brighter when blinking than steady state
would allow for.
Rob
next prev parent reply other threads:[~2020-12-09 19:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 10:46 [PATCH v11 0/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-12-02 10:46 ` [PATCH v11 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Gene Chen
2020-12-02 10:46 ` [PATCH v11 2/5] leds: flash: Fix multicolor no-ops registration by return 0 Gene Chen
2020-12-02 10:46 ` [PATCH v11 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions Gene Chen
2020-12-02 12:23 ` Pavel Machek
2020-12-03 6:42 ` Gene Chen
2020-12-03 11:40 ` Pavel Machek
2020-12-03 20:06 ` Jacek Anaszewski
2020-12-09 19:53 ` Rob Herring [this message]
2020-12-02 10:46 ` [PATCH v11 4/5] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-12-03 20:24 ` Jacek Anaszewski
2020-12-09 19:58 ` Rob Herring
2020-12-02 10:46 ` [PATCH v11 5/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-12-02 18:27 ` kernel test robot
2020-12-02 20:37 ` kernel test robot
2020-12-03 20:35 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209195336.GB826766@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).