From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B3BC4361B for ; Wed, 9 Dec 2020 23:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C3AF22CE3 for ; Wed, 9 Dec 2020 23:24:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387729AbgLIXY5 (ORCPT ); Wed, 9 Dec 2020 18:24:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47492 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgLIXY5 (ORCPT ); Wed, 9 Dec 2020 18:24:57 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kn8oZ-00B8Oc-0L; Thu, 10 Dec 2020 00:24:07 +0100 Date: Thu, 10 Dec 2020 00:24:06 +0100 From: Andrew Lunn To: Pavana Sharma Cc: ashkan.boldaji@digi.com, clang-built-linux@googlegroups.com, davem@davemloft.net, devicetree@vger.kernel.org, f.fainelli@gmail.com, gregkh@linuxfoundation.org, kbuild-all@lists.01.org, kuba@kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, marek.behun@nic.cz, netdev@vger.kernel.org, robh+dt@kernel.org, vivien.didelot@gmail.com Subject: Re: [PATCH v11 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int Message-ID: <20201209232406.GH2649111@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Wed, Dec 09, 2020 at 03:05:17PM +1000, Pavana Sharma wrote: > Returning 0 is no more an error case with MV88E6393 family > which has serdes lane numbers 0, 9 or 10. > So with this change .serdes_get_lane will return lane number > or -errno (-ENODEV or -EOPNOTSUPP). > > Signed-off-by: Pavana Sharma I see here you did actually act on my comment. Thanks. But i also said: > Other than that: > > Reviewed-by: Andrew Lunn Please add such tags to new versions of the patches. It then makes it easier for everybody to know the review state of the patches, which have been reviewed and deemed O.K, and which need more review. Thanks Andrew