From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BF1C433FE for ; Thu, 10 Dec 2020 01:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C35922D49 for ; Thu, 10 Dec 2020 01:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725829AbgLJBhX (ORCPT ); Wed, 9 Dec 2020 20:37:23 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47768 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbgLJBhX (ORCPT ); Wed, 9 Dec 2020 20:37:23 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1knAsm-00B99H-VQ; Thu, 10 Dec 2020 02:36:36 +0100 Date: Thu, 10 Dec 2020 02:36:36 +0100 From: Andrew Lunn To: Rasmus Villemoes Cc: Li Yang , "David S. Miller" , Jakub Kicinski , Zhao Qiang , Vladimir Oltean , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/20] ethernet: ucc_geth: use qe_muram_free_addr() Message-ID: <20201210013636.GC2638572@lunn.ch> References: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> <20201205191744.7847-8-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201205191744.7847-8-rasmus.villemoes@prevas.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2020 at 08:17:30PM +0100, Rasmus Villemoes wrote: > This removes the explicit NULL checks, and allows us to stop storing > at least some of the _offset values separately. > > Signed-off-by: Rasmus Villemoes This seems to rely on one of the missing patches. Please don't split patches like this, it makes review very difficult. Andrew