* [PATCH] kexec: Fix error code in kexec_calculate_store_digests()
@ 2020-12-09 6:55 Dan Carpenter
2020-12-10 2:05 ` Dave Young
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-12-09 6:55 UTC (permalink / raw)
To: Eric Biederman, Dave Young; +Cc: kexec, linux-kernel, kernel-janitors
Return -ENOMEM on allocation failure instead of returning success.
Fixes: a43cac0d9dc2 ("kexec: split kexec_file syscall code to kexec_file.c")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
kernel/kexec_file.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index b02086d70492..9570f380a825 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -735,8 +735,10 @@ static int kexec_calculate_store_digests(struct kimage *image)
sha_region_sz = KEXEC_SEGMENT_MAX * sizeof(struct kexec_sha_region);
sha_regions = vzalloc(sha_region_sz);
- if (!sha_regions)
+ if (!sha_regions) {
+ ret = -ENOMEM;
goto out_free_desc;
+ }
desc->tfm = tfm;
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kexec: Fix error code in kexec_calculate_store_digests()
2020-12-09 6:55 [PATCH] kexec: Fix error code in kexec_calculate_store_digests() Dan Carpenter
@ 2020-12-10 2:05 ` Dave Young
0 siblings, 0 replies; 2+ messages in thread
From: Dave Young @ 2020-12-10 2:05 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Eric Biederman, kexec, linux-kernel, kernel-janitors
On 12/08/20 at 10:55pm, Dan Carpenter wrote:
> Return -ENOMEM on allocation failure instead of returning success.
>
> Fixes: a43cac0d9dc2 ("kexec: split kexec_file syscall code to kexec_file.c")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> kernel/kexec_file.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index b02086d70492..9570f380a825 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -735,8 +735,10 @@ static int kexec_calculate_store_digests(struct kimage *image)
>
> sha_region_sz = KEXEC_SEGMENT_MAX * sizeof(struct kexec_sha_region);
> sha_regions = vzalloc(sha_region_sz);
> - if (!sha_regions)
> + if (!sha_regions) {
> + ret = -ENOMEM;
> goto out_free_desc;
> + }
>
> desc->tfm = tfm;
>
> --
> 2.29.2
>
Good catch, thanks!
Acked-by: Dave Young <dyoung@redhat.com>
Thanks
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-10 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 6:55 [PATCH] kexec: Fix error code in kexec_calculate_store_digests() Dan Carpenter
2020-12-10 2:05 ` Dave Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).