From: Rob Herring <robh@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Nick Dyer <nick@shmanahar.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jiada Wang <jiada_wang@mentor.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: input: atmel_mxt_ts: Document atmel,wakeup-method and wake-GPIO
Date: Wed, 9 Dec 2020 21:44:20 -0600 [thread overview]
Message-ID: <20201210034420.GA1615537@robh.at.kernel.org> (raw)
In-Reply-To: <20201206212217.6857-2-digetx@gmail.com>
On Mon, Dec 07, 2020 at 12:22:15AM +0300, Dmitry Osipenko wrote:
> Some Atmel touchscreen controllers have a WAKE line that needs to be
> asserted low in order to wake up controller from a deep sleep. Document
> the wakeup methods and the wake-GPIO properties.
wake-GPIO?
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../bindings/input/atmel,maxtouch.yaml | 29 +++++++++++++++++++
> include/dt-bindings/input/atmel-maxtouch.h | 10 +++++++
> 2 files changed, 39 insertions(+)
> create mode 100644 include/dt-bindings/input/atmel-maxtouch.h
>
> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> index 8c6418f76e94..e6b03a1e7c30 100644
> --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> @@ -39,6 +39,13 @@ properties:
> (active low). The line must be flagged with
> GPIO_ACTIVE_LOW.
>
> + wake-gpios:
> + maxItems: 1
> + description:
> + Optional GPIO specifier for the touchscreen's wake pin
> + (active low). The line must be flagged with
> + GPIO_ACTIVE_LOW.
> +
> linux,gpio-keymap:
> $ref: /schemas/types.yaml#/definitions/uint32-array
> description: |
> @@ -53,6 +60,26 @@ properties:
> or experiment to determine which bit corresponds to which input. Use
> KEY_RESERVED for unused padding values.
>
> + atmel,wakeup-method:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The WAKE line is an active-low input that is used to wake up the touch
> + controller from deep-sleep mode before communication with the controller
> + could be started. This optional feature used to minimize current
> + consumption when the controller is in deep sleep mode. This feature is
> + relevant only to some controller families, like mXT1386 controller for
> + example.
> +
> + The WAKE pin can be connected in one of the following ways:
> + 1) left permanently low
> + 2) connected to the I2C-compatible SCL pin
> + 3) connected to a GPIO pin on the host
> + enum:
> + - 0 # ATMEL_MXT_WAKEUP_NONE
> + - 1 # ATMEL_MXT_WAKEUP_I2C_SCL
> + - 2 # ATMEL_MXT_WAKEUP_GPIO
> + default: 0
> +
> required:
> - compatible
> - reg
> @@ -63,6 +90,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/input/atmel-maxtouch.h>
> #include <dt-bindings/gpio/gpio.h>
> i2c {
> #address-cells = <1>;
> @@ -75,6 +103,7 @@ examples:
> reset-gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
> vdda-supply = <&ab8500_ldo_aux2_reg>;
> vdd-supply = <&ab8500_ldo_aux5_reg>;
> + atmel,wakeup-method = <ATMEL_MXT_WAKEUP_I2C_SCL>;
> };
> };
>
> diff --git a/include/dt-bindings/input/atmel-maxtouch.h b/include/dt-bindings/input/atmel-maxtouch.h
> new file mode 100644
> index 000000000000..7345ab32224d
> --- /dev/null
> +++ b/include/dt-bindings/input/atmel-maxtouch.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +
> +#ifndef _DT_BINDINGS_ATMEL_MAXTOUCH_H
> +#define _DT_BINDINGS_ATMEL_MAXTOUCH_H
> +
> +#define ATMEL_MXT_WAKEUP_NONE 0
> +#define ATMEL_MXT_WAKEUP_I2C_SCL 1
> +#define ATMEL_MXT_WAKEUP_GPIO 2
> +
> +#endif /* _DT_BINDINGS_ATMEL_MAXTOUCH_H */
> --
> 2.29.2
>
next prev parent reply other threads:[~2020-12-10 3:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 21:22 [PATCH v3 0/3] Support wakeup methods of Atmel maXTouch controllers Dmitry Osipenko
2020-12-06 21:22 ` [PATCH v3 1/3] dt-bindings: input: atmel_mxt_ts: Document atmel,wakeup-method and wake-GPIO Dmitry Osipenko
2020-12-10 3:44 ` Rob Herring [this message]
2020-12-10 9:57 ` Dmitry Osipenko
2020-12-06 21:22 ` [PATCH v3 2/3] Input: atmel_mxt_ts - support wakeup methods Dmitry Osipenko
2020-12-06 21:22 ` [PATCH v3 3/3] ARM: tegra: acer-a500: Add atmel,wakeup-method property Dmitry Osipenko
2020-12-12 2:43 ` [PATCH v3 0/3] Support wakeup methods of Atmel maXTouch controllers Dmitry Torokhov
2020-12-12 7:54 ` Dmitry Osipenko
2020-12-13 4:41 ` Dmitry Torokhov
2020-12-13 9:26 ` Dmitry Osipenko
2021-01-07 22:05 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210034420.GA1615537@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jiada_wang@mentor.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).