From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC0DC4361B for ; Thu, 10 Dec 2020 12:59:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB3FD23D6C for ; Thu, 10 Dec 2020 12:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388477AbgLJM7C (ORCPT ); Thu, 10 Dec 2020 07:59:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728462AbgLJM6u (ORCPT ); Thu, 10 Dec 2020 07:58:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2505C0613D6 for ; Thu, 10 Dec 2020 04:58:09 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knLWE-00063I-Pt; Thu, 10 Dec 2020 13:58:02 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1knLWD-0004ic-4E; Thu, 10 Dec 2020 13:58:01 +0100 Date: Thu, 10 Dec 2020 13:58:00 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Lino Sanfilippo Cc: thierry.reding@gmail.com, lee.jones@linaro.org, nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com, sean@mess.org, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] pwm: bcm2835: Support apply function for atomic configuration Message-ID: <20201210125800.gj4f4rioq7df4hbl@pengutronix.de> References: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6tvo3blcdefqpmbe" Content-Disposition: inline In-Reply-To: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6tvo3blcdefqpmbe Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 09, 2020 at 09:48:25PM +0100, Lino Sanfilippo wrote: > Use the newer .apply function of pwm_ops instead of .config, .enable, > .disable and .set_polarity. This guarantees atomic changes of the pwm > controller configuration. It also reduces the size of the driver. >=20 > Since now period is a 64 bit value, add an extra check to reject periods > that exceed the possible max value for the 32 bit register. >=20 > This has been tested on a Raspberry PI 4. >=20 > Signed-off-by: Lino Sanfilippo I replied to v3 earlier, this was supposed to go to this v4 of course. Still had v3 open for comparing the two. So to ensure it is picked up: Reviewed-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --6tvo3blcdefqpmbe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl/SG1UACgkQwfwUeK3K 7AlHQQf/Vw6TeRvt4v1Bz3mRlclNw2+/Tcu0VHY8orK2+FYUzUZ4c1ywNmdycxsQ 9FSssC5fW3kLq1rTZnXe0m2dcvj1whY6PIprRo+BSrS5gmF7uc5py5NjstFxA0Z6 aSgMu/L6irP/g8dQUFvzMzSMEhCmqSVqOKGwFGKsMxGbzbp5J6peztQJp0/CxtQo 1G2GGbVKtSnGQsAgO3x3ePXrUj11J9UHtTOSJFDIwIp/DWjm1zatDK4yEsjI2NU1 tdpv2fFpUe/CUfpNqLW31ZJrez8QkJic1LGQ4b/FVbD3LOUQEw7zjDFpGr7XQ5un xnlbU/YWSJmZ7I77pfLgiZzu2w2iOg== =DB1h -----END PGP SIGNATURE----- --6tvo3blcdefqpmbe--