From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end()
Date: Thu, 10 Dec 2020 18:07:23 +0100 [thread overview]
Message-ID: <20201210170723.GD1578121@piout.net> (raw)
In-Reply-To: <ec71d7b8-a36b-04f5-77a8-22874ac241e1@web.de>
On 10/12/2020 17:35:31+0100, Markus Elfring wrote:
> >> A local variable was used only within an if branch.
> >> Thus move the definition for the variable “slot” into the corresponding
> >> code block.
> >>
> >
> > What is the improvement here?
>
> A possible refactoring.
> https://refactoring.com/catalog/reduceScopeOfVariable.html
>
I quote:
"Since declarations of variables in many cases costs computational
cycles, you may end up wasting time for nothing."
This is false, it doesn't.
I also quote:
"When I'm writing new code I find I don't scope my temps any less than
method scope. This is because I keep my methods short, so reducing scope
any further doesn't add much value. The value of this refactoring is in
breaking up a large method."
Is that function large? It is not.
>
> > This makes the code harder to read.
>
> Can the extra null pointer initialisation trigger a source code analysis warning
> like “Addresses-Coverity: ("Unused value")” for this function implementation?
>
Did you check, does it? It doesn't.
Are you wasting maintainer and reviewer's time? Yes you are.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-12-10 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <466b4c6d-032f-fbcc-58ac-75f6f39d734f@web.de>
2020-12-10 15:10 ` [PATCH] mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end() Alexandre Belloni
[not found] ` <ec71d7b8-a36b-04f5-77a8-22874ac241e1@web.de>
2020-12-10 17:07 ` Alexandre Belloni [this message]
[not found] ` <2667790c-fad2-aaa9-36e8-6be66949ac8d@web.de>
2020-12-10 18:21 ` Alexandre Belloni
[not found] ` <4c0d8efe-de25-f168-8b8d-b7f1ede6c6b1@web.de>
2020-12-11 8:03 ` Alexandre Belloni
2020-12-12 9:16 ` Joe Perches
2020-12-12 13:17 ` Alexandre Belloni
2020-12-12 18:48 ` Joe Perches
2020-12-11 8:37 ` [PATCH] " Dan Carpenter
[not found] ` <e7910b04-4c4a-567b-d87d-d12352a48cfc@web.de>
2020-12-14 7:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210170723.GD1578121@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).