linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger level on TM2
@ 2020-12-10 21:18 Krzysztof Kozlowski
  2020-12-29 16:00 ` (subset) " Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-10 21:18 UTC (permalink / raw)
  To: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Bongsu Jeon

The S3FWRN5 datasheet describe the interrupt line as rising edge.  The
current configuration as level high, could cause spurious interrupts.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 03486a8ffc67..174ea507192d 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -793,7 +793,7 @@ s3fwrn5: nfc@27 {
 		compatible = "samsung,s3fwrn5-i2c";
 		reg = <0x27>;
 		interrupt-parent = <&gpa1>;
-		interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <3 IRQ_TYPE_EDGE_RISING>;
 		en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
 		wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
 	};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: (subset) [PATCH] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger level on TM2
  2020-12-10 21:18 [PATCH] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger level on TM2 Krzysztof Kozlowski
@ 2020-12-29 16:00 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-29 16:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski, linux-samsung-soc, linux-arm-kernel,
	devicetree, linux-kernel
  Cc: Bongsu Jeon

On Thu, 10 Dec 2020 22:18:58 +0100, Krzysztof Kozlowski wrote:
> The S3FWRN5 datasheet describe the interrupt line as rising edge.  The
> current configuration as level high, could cause spurious interrupts.

Applied, thanks!

[1/1] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger level on TM2
      commit: d497d07b74f05f01b9c8c85b6679c2df57ecbdb4

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-29 16:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 21:18 [PATCH] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger level on TM2 Krzysztof Kozlowski
2020-12-29 16:00 ` (subset) " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).