From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type
Date: Fri, 11 Dec 2020 08:52:21 +0100 [thread overview]
Message-ID: <20201211075221.GB4346@kozik-lap> (raw)
In-Reply-To: <20201210221600.anob3tojbawjhehs@earth.universe>
On Thu, Dec 10, 2020 at 11:16:00PM +0100, Sebastian Reichel wrote:
> (I shortened the Cc)
>
> Hi,
>
> On Thu, Dec 10, 2020 at 10:25:34PM +0100, Krzysztof Kozlowski wrote:
> > [...]
> > index d956c67d5155..f737de0470de 100644
> > --- a/drivers/power/supply/max17040_battery.c
> > +++ b/drivers/power/supply/max17040_battery.c
> > @@ -367,7 +367,7 @@ static int max17040_enable_alert_irq(struct max17040_chip *chip)
> >
> > flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
> > ret = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> > - max17040_thread_handler, flags,
> > + max17040_thread_handler, IRQF_ONESHOT,
> > chip->battery->desc->name, chip);
> >
> > return ret;
>
> 'flags' is unused after this change.
Indeed, thanks. Kbuild also complained now on my github branch. I'll fix
it in v2.
next prev parent reply other threads:[~2020-12-11 7:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 21:25 [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 02/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on P4 Note family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family Krzysztof Kozlowski
2020-12-29 15:43 ` Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 04/18] ARM: dts: exynos: correct MUIC " Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 05/18] ARM: dts: exynos: correct PMIC " Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 06/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid X/U3 family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 07/18] ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 08/18] ARM: dts: exynos: correct PMIC interrupt trigger level on SMDK5250 Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 09/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Snow Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 10/18] ARM: dts: s5pv210: correct fuel gauge interrupt trigger level on Fascinate family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 11/18] ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level Krzysztof Kozlowski
2020-12-11 15:29 ` Iskren Chernev
2020-12-10 21:25 ` [PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: " Krzysztof Kozlowski
2020-12-11 15:25 ` Iskren Chernev
2020-12-10 21:25 ` [RFC 13/18] mfd: max77686: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2020-12-21 18:45 ` Rob Herring
2020-12-10 21:25 ` [RFC 14/18] rtc: " Krzysztof Kozlowski
2020-12-10 21:25 ` [RFC 15/18] mfd: max77693: " Krzysztof Kozlowski
2020-12-21 18:46 ` Rob Herring
2020-12-10 21:25 ` [RFC 16/18] power: supply: max17042: " Krzysztof Kozlowski
2020-12-10 21:25 ` [RFC 17/18] mfd: max14577: " Krzysztof Kozlowski
2020-12-21 18:47 ` Rob Herring
2020-12-10 21:25 ` [RFC 18/18] power: supply: max17040: " Krzysztof Kozlowski
2020-12-10 22:16 ` Sebastian Reichel
2020-12-11 7:52 ` Krzysztof Kozlowski [this message]
2020-12-11 7:47 ` Krzysztof Kozlowski
2020-12-11 15:44 ` Iskren Chernev
2020-12-11 15:51 ` Krzysztof Kozlowski
2021-03-03 18:19 ` [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211075221.GB4346@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).