From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A870AC4361B for ; Fri, 11 Dec 2020 08:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 469E923DC4 for ; Fri, 11 Dec 2020 08:37:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391911AbgLKIgl (ORCPT ); Fri, 11 Dec 2020 03:36:41 -0500 Received: from mga04.intel.com ([192.55.52.120]:55312 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405556AbgLKIgL (ORCPT ); Fri, 11 Dec 2020 03:36:11 -0500 IronPort-SDR: AA4UKQR4QnUrzmfiaJ2I3UI2y7baUlpKBAraTUTYxuVPXVBzaw2CDuIQ9/fUSuGLh10FpQ8Rvs b+2hU9FydyVg== X-IronPort-AV: E=McAfee;i="6000,8403,9831"; a="171834962" X-IronPort-AV: E=Sophos;i="5.78,410,1599548400"; d="scan'208";a="171834962" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2020 00:34:25 -0800 IronPort-SDR: MepZUPw4n7yaP6+BJ2h90WShZTk66uXqJXOt4z/KY1pLKtJBzHOqDVUZbkM0tVcr3w/vgILBmc xdMwdAgtEm8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,410,1599548400"; d="scan'208";a="440614654" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 11 Dec 2020 00:34:23 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 11 Dec 2020 10:34:22 +0200 Date: Fri, 11 Dec 2020 10:34:22 +0200 From: Heikki Krogerus To: Badhri Jagan Sridharan Cc: Guenter Roeck , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: tcpci: Enable bleed discharge when auto discharge is enabled Message-ID: <20201211083422.GF1594451@kuha.fi.intel.com> References: <20201211071145.2199997-1-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211071145.2199997-1-badhri@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 11:11:45PM -0800, Badhri Jagan Sridharan wrote: > Auto discharge circuits kick in only when vbus decays and reaches > VBUS_SINK_DISCONNECT_THRESHOLD threshold. Enable bleed discharge to > discharge vbus to VBUS_SINK_DISCONNECT_THRESHOLD upon disconnect. > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm/tcpci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c > index af5524338a63..f676abab044b 100644 > --- a/drivers/usb/typec/tcpm/tcpci.c > +++ b/drivers/usb/typec/tcpm/tcpci.c > @@ -725,6 +725,8 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data) > tcpci->tcpc.enable_auto_vbus_discharge = tcpci_enable_auto_vbus_discharge; > tcpci->tcpc.set_auto_vbus_discharge_threshold = > tcpci_set_auto_vbus_discharge_threshold; > + regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL, TCPC_POWER_CTRL_BLEED_DISCHARGE, > + TCPC_POWER_CTRL_BLEED_DISCHARGE); > } > > if (tcpci->data->vbus_vsafe0v) > -- > 2.29.2.576.ga3fc446d84-goog -- heikki