From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD0A6C4361B for ; Fri, 11 Dec 2020 17:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70C8D23DC2 for ; Fri, 11 Dec 2020 17:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406787AbgLKQad (ORCPT ); Fri, 11 Dec 2020 11:30:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406784AbgLKQ37 (ORCPT ); Fri, 11 Dec 2020 11:29:59 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C71C0613D6 for ; Fri, 11 Dec 2020 08:29:19 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id a11so1901303wrr.13 for ; Fri, 11 Dec 2020 08:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=upnpTTVn3TTWnoBpvg+IxCXBj8DZMW4qDQhpIs6vKnQ=; b=yqBXJKEs5arzaQbSaGUArBaahtoFHUiEQ15v93dp6DK4J99ZvNwBain8TbJqJc5uUF UOtugLKuan7n88JB6JjhlZugxs4mQ9BCraPdTEilJjxeiIwt+Jhsw2zQWjovodejZ/xW MkAKHYlJhLnoABpVH45p/4mNr+Oqi+aWuKrnCsUv9lBmyoR1sNYwaF4gr/TrX738Aznq qDBw3/jqFzZb6Ei5P/ACaHHq12KOtMFxXpXKWmWyl86+ypZa0WFurz3huU3CeUBG2J51 WMJ3I0sAwr/9eLC6/nsK9343EWyNWJ1d5r5aniFs2y/+75fsaeK1VBGhIi+0Lf3Jw9g9 Em0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=upnpTTVn3TTWnoBpvg+IxCXBj8DZMW4qDQhpIs6vKnQ=; b=hWn1j1Fg1ukWx8YWWLS9jGKhi1F9bWkPTOdnc1gTej7IlDkz9jyyzYvchCutTW5CoP LWtnjKbeBv1+AhzZZQXyiUQH8M/us6t0lGfAkaV90mZFcuLwNQHKIJDxSrl8ck6jjVJ7 L527ZH56xIeOgCXNN38dcf5Iy7xYY7DgMspUEpEsT0FNyz4zy8scRKZkqbpwHA7O8KF4 lrcRowvAwkrqVUJ9I6u1x+tKQWWqkNkYR2FyAt5yBAGsELmcnrzZ44DmhGKTJHe7ukwG v1mqWLElTdMRKSvjqHQTW6F9BdyjhcfuUK0J8Nzo5vwlxLanySeTxS1UgmGtPQAX28qp CBVg== X-Gm-Message-State: AOAM5328ScATVsQAIv5yfhtjBz6hAFNGjx7gkS/GjaohmeUSgcIXG9BP ZBu2bwtrct+6i6Jfx1Ikltk+VQ== X-Google-Smtp-Source: ABdhPJxXdCgHsceI7aeSJLKx3YVhbJyQ8+v+J6x5gbPn9vnHelX7UtD/uPKDshJ7T1SoW8bHewCe6Q== X-Received: by 2002:adf:da4f:: with SMTP id r15mr5016152wrl.364.1607704157985; Fri, 11 Dec 2020 08:29:17 -0800 (PST) Received: from holly.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id k10sm13536716wrq.38.2020.12.11.08.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 08:29:16 -0800 (PST) Date: Fri, 11 Dec 2020 16:29:14 +0000 From: Daniel Thompson To: Ioana Ciornei Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing Message-ID: <20201211162914.pa3eua4nerviysyy@holly.lan> References: <20200629184712.12449-2-ioana.ciornei () nxp ! com> <20201210173156.mbizovo6rxvkda73@holly.lan> <20201210180636.nsfwvzs5xxzpqt7n@skbuf> <20201211140126.25x4z2x6upctyin5@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211140126.25x4z2x6upctyin5@skbuf> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2020 at 02:01:28PM +0000, Ioana Ciornei wrote: > On Thu, Dec 10, 2020 at 08:06:36PM +0200, Ioana Ciornei wrote: > > [Added also the netdev mailing list, I haven't heard of linux-netdev > > before but kept it] > > > > On Thu, Dec 10, 2020 at 05:31:56PM +0000, Daniel Thompson wrote: > > > Hi Ioana > > > > Hi Daniel, > > > > > > > > On Mon, Jun 29, 2020 at 06:47:11PM +0000, Ioana Ciornei wrote: > > > > Instead of realloc-ing the skb on the Tx path when the provided headroom > > > > is smaller than the HW requirements, create a Scatter/Gather frame > > > > descriptor with only one entry. > > > > > > > > Remove the '[drv] tx realloc frames' counter exposed previously through > > > > ethtool since it is no longer used. > > > > > > > > Signed-off-by: Ioana Ciornei > > > > --- > > > > > > I've been chasing down a networking regression on my LX2160A board > > > (Honeycomb LX2K based on CEx7 LX2160A COM) that first appeared in v5.9. > > > > > > It makes the board unreliable opening outbound connections meaning > > > things like `apt update` or `git fetch` often can't open the connection. > > > It does not happen all the time but is sufficient to make the boards > > > built-in networking useless for workstation use. > > > > > > The problem is strongly linked to warnings in the logs so I used the > > > warnings to bisect down to locate the cause of the regression and it > > > pinpointed this patch. I have confirmed that in both v5.9 and v5.10-rc7 > > > that reverting this patch (and fixing up the merge issues) fixes the > > > regression and the warnings stop appearing. > > > > > > A typical example of the warning is below (io-pgtable-arm.c:281 is an > > > error path that I guess would cause dma_map_page_attrs() to return > > > an error): > > > > > > [ 714.464927] WARNING: CPU: 13 PID: 0 at > > > drivers/iommu/io-pgtable-arm.c:281 __arm_lpae_map+0x2d4/0x30c > > > [ 714.464930] Modules linked in: snd_seq_dummy(E) snd_hrtimer(E) > > > snd_seq(E) snd_seq_device(E) snd_timer(E) snd(E) soundcore(E) bridge(E) > > > stp(E) llc(E) rfkill(E) caam_jr(E) crypto_engine(E) rng_core(E) > > > joydev(E) evdev(E) dpaa2_caam(E) caamhash_desc(E) caamalg_desc(E) > > > authenc(E) libdes(E) dpaa2_console(E) ofpart(E) caam(E) sg(E) error(E) > > > lm90(E) at24(E) spi_nor(E) mtd(E) sbsa_gwdt(E) qoriq_thermal(E) > > > layerscape_edac_mod(E) qoriq_cpufreq(E) drm(E) fuse(E) configfs(E) > > > ip_tables(E) x_tables(E) autofs4(E) ext4(E) crc32c_generic(E) crc16(E) > > > mbcache(E) jbd2(E) hid_generic(E) usbhid(E) hid(E) dm_crypt(E) dm_mod(E) > > > sd_mod(E) fsl_dpaa2_ptp(E) ptp_qoriq(E) fsl_dpaa2_eth(E) > > > xhci_plat_hcd(E) xhci_hcd(E) usbcore(E) aes_ce_blk(E) crypto_simd(E) > > > cryptd(E) aes_ce_cipher(E) ghash_ce(E) gf128mul(E) at803x(E) libaes(E) > > > fsl_mc_dpio(E) pcs_lynx(E) rtc_pcf2127(E) sha2_ce(E) phylink(E) > > > xgmac_mdio(E) regmap_spi(E) of_mdio(E) sha256_arm64(E) > > > i2c_mux_pca954x(E) fixed_phy(E) i2c_mux(E) sha1_ce(E) ptp(E) libphy(E) > > > [ 714.465131] pps_core(E) ahci_qoriq(E) libahci_platform(E) nvme(E) > > > libahci(E) nvme_core(E) t10_pi(E) libata(E) crc_t10dif(E) > > > crct10dif_generic(E) crct10dif_common(E) dwc3(E) scsi_mod(E) udc_core(E) > > > roles(E) ulpi(E) sdhci_of_esdhc(E) sdhci_pltfm(E) sdhci(E) > > > spi_nxp_fspi(E) i2c_imx(E) fixed(E) > > > [ 714.465192] CPU: 13 PID: 0 Comm: swapper/13 Tainted: G W E > > > 5.10.0-rc7-00001-gba98d13279ca #52 > > > [ 714.465196] Hardware name: SolidRun LX2160A Honeycomb (DT) > > > [ 714.465202] pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--) > > > [ 714.465207] pc : __arm_lpae_map+0x2d4/0x30c > > > [ 714.465211] lr : __arm_lpae_map+0x114/0x30c > > > [ 714.465215] sp : ffff80001006b340 > > > [ 714.465219] x29: ffff80001006b340 x28: 0000002086538003 > > > [ 714.465227] x27: 0000000000000a20 x26: 0000000000001000 > > > [ 714.465236] x25: 0000000000000f44 x24: 00000020adf8d000 > > > [ 714.465245] x23: 0000000000000001 x22: 0000fffffaeca000 > > > [ 714.465253] x21: 0000000000000003 x20: ffff19b60d64d200 > > > [ 714.465261] x19: 00000000000000ca x18: 0000000000000000 > > > [ 714.465270] x17: 0000000000000000 x16: ffffcccb7cf3ca20 > > > [ 714.465278] x15: 0000000000000000 x14: 0000000000000000 > > > [ 714.465286] x13: 0000000000000003 x12: 0000000000000010 > > > [ 714.465294] x11: 0000000000000000 x10: 0000000000000002 > > > [ 714.465302] x9 : ffffcccb7d5b6e78 x8 : 00000000000001ff > > > [ 714.465311] x7 : ffff19b606538650 x6 : ffff19b606538000 > > > [ 714.465319] x5 : 0000000000000009 x4 : 0000000000000f44 > > > [ 714.465327] x3 : 0000000000001000 x2 : 00000020adf8d000 > > > [ 714.465335] x1 : 0000000000000002 x0 : 0000000000000003 > > > [ 714.465343] Call trace: > > > [ 714.465348] __arm_lpae_map+0x2d4/0x30c > > > [ 714.465353] __arm_lpae_map+0x114/0x30c > > > [ 714.465357] __arm_lpae_map+0x114/0x30c > > > [ 714.465362] __arm_lpae_map+0x114/0x30c > > > [ 714.465366] arm_lpae_map+0xf4/0x180 > > > [ 714.465373] arm_smmu_map+0x4c/0xc0 > > > [ 714.465379] __iommu_map+0x100/0x2bc > > > [ 714.465385] iommu_map_atomic+0x20/0x30 > > > [ 714.465391] __iommu_dma_map+0xb0/0x110 > > > [ 714.465397] iommu_dma_map_page+0xb8/0x120 > > > [ 714.465404] dma_map_page_attrs+0x1a8/0x210 > > > [ 714.465413] __dpaa2_eth_tx+0x384/0xbd0 [fsl_dpaa2_eth] > > > [ 714.465421] dpaa2_eth_tx+0x84/0x134 [fsl_dpaa2_eth] > > > [ 714.465427] dev_hard_start_xmit+0x10c/0x2b0 > > > [ 714.465433] sch_direct_xmit+0x1a0/0x550 > > > [ 714.465438] __qdisc_run+0x140/0x670 > > > [ 714.465443] __dev_queue_xmit+0x6c4/0xa74 > > > [ 714.465449] dev_queue_xmit+0x20/0x2c > > > [ 714.465463] br_dev_queue_push_xmit+0xc4/0x1a0 [bridge] > > > [ 714.465476] br_forward_finish+0xdc/0xf0 [bridge] > > > [ 714.465489] __br_forward+0x160/0x1c0 [bridge] > > > [ 714.465502] br_forward+0x13c/0x160 [bridge] > > > [ 714.465514] br_dev_xmit+0x228/0x3b0 [bridge] > > > [ 714.465520] dev_hard_start_xmit+0x10c/0x2b0 > > > [ 714.465526] __dev_queue_xmit+0x8f0/0xa74 > > > [ 714.465531] dev_queue_xmit+0x20/0x2c > > > [ 714.465538] arp_xmit+0xc0/0xd0 > > > [ 714.465544] arp_send_dst+0x78/0xa0 > > > [ 714.465550] arp_solicit+0xf4/0x260 > > > [ 714.465554] neigh_probe+0x64/0xb0 > > > [ 714.465560] neigh_timer_handler+0x2f4/0x400 > > > [ 714.465566] call_timer_fn+0x3c/0x184 > > > [ 714.465572] __run_timers.part.0+0x2bc/0x370 > > > [ 714.465578] run_timer_softirq+0x48/0x80 > > > [ 714.465583] __do_softirq+0x120/0x36c > > > [ 714.465589] irq_exit+0xac/0x100 > > > [ 714.465596] __handle_domain_irq+0x8c/0xf0 > > > [ 714.465600] gic_handle_irq+0xcc/0x14c > > > [ 714.465605] el1_irq+0xc4/0x180 > > > [ 714.465610] arch_cpu_idle+0x18/0x30 > > > [ 714.465617] default_idle_call+0x4c/0x180 > > > [ 714.465623] do_idle+0x238/0x2b0 > > > [ 714.465629] cpu_startup_entry+0x30/0xa0 > > > [ 714.465636] secondary_start_kernel+0x134/0x180 > > > [ 714.465640] ---[ end trace a84a7f61b559005f ]--- > > > > > > > > > Given it is the iommu code that is provoking the warning I should > > > probably mention that the board I have requires > > > arm-smmu.disable_bypass=0 on the kernel command line in order to boot. > > > Also if it matters I am running the latest firmware from Solidrun > > > which is based on LSDK-20.04. > > > > > > > Hmmm, from what I remember I think I tested this with the smmu bypassed > > so that is why I didn't catch it. > > > > > Is there any reason for this code not to be working for LX2160A? > > > > I wouldn't expect this to be LX2160A specific but rather a bug in the > > implementation.. sorry. > > > > Let me reproduce it and see if I can get to the bottom of it and I will > > get back with some more info. > > > > Hi Daniel, > > It seems that the dma-unmapping on the SGT buffer was incorrectly done > with a zero size since on the Tx path I initialized the improper field. > > Could you test the following diff and let me know if you can generate > the WARNINGs anymore? I fired this up and, with your change, I've not been able to trigger the warning with the tests that I used the drive my bisect. Thanks for the quick response. Daniel. > > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > @@ -878,7 +878,7 @@ static int dpaa2_eth_build_sg_fd_single_buf(struct dpaa2_eth_priv *priv, > swa = (struct dpaa2_eth_swa *)sgt_buf; > swa->type = DPAA2_ETH_SWA_SINGLE; > swa->single.skb = skb; > - swa->sg.sgt_size = sgt_buf_size; > + swa->single.sgt_size = sgt_buf_size; > > /* Separately map the SGT buffer */ > sgt_addr = dma_map_single(dev, sgt_buf, sgt_buf_size, DMA_BIDIRECTIONAL); > > > Ioana