linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Ahmed S . Darwish" <a.darwish@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] sr: Remove in_interrupt() usage in sr_init_command().
Date: Fri, 11 Dec 2020 18:09:15 +0100	[thread overview]
Message-ID: <20201211170915.4bs2huyptnsmlwvf@linutronix.de> (raw)
In-Reply-To: <20201204164850.2343359-3-bigeasy@linutronix.de>

On 2020-12-04 17:48:50 [+0100], To linux-scsi@vger.kernel.org wrote:
> The in_interrupt() check in sr_init_command() is a leftover from the
> past, pre v2.3.16 era to be exact. Back then the ioctl() was served by
> `sr' itself and sector size changes by CDROMREADMODE2 (as noted in the
> comment) were accounted within sr's data structures which allowed a
> "lazy" reset so it could be skipped on the next request and reset back
> to the default value once the device node was closed or before a command
> from the blockqueue was issued.
> 
> This does not work like that anymore. The CDROMREADMODE2 is served by
> cdrom's mmc_ioctl() function which may change the sector size but the
> `sr' driver does not learn about it and so its ->sector_size is not
> updated.
> The ioctl() resets the changed sector size back to 2048.
> sr_read_sector() also resets the sector size back to the default once it
> is done.
> 
> Remove the conditional sector size update from sr_init_command() and
> sr_release() because it is not needed.
> 
> Link: https://lkml.kernel.org/r/20201204164803.ovwurzs3257em2rp@linutronix.de
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Any chance to get this reviewed/merged?

Sebastian

  reply	other threads:[~2020-12-11 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 16:48 [PATCH 0/3] Remove in_interrupt() usage in sr Sebastian Andrzej Siewior
2020-12-04 16:48 ` [PATCH 1/3] cdrom: Reset sector_size back it is not 2048 Sebastian Andrzej Siewior
2020-12-04 16:48   ` [PATCH 2/3] sr: Switch the sector size back to 2048 if sr_read_sector() changed it Sebastian Andrzej Siewior
2020-12-04 16:48   ` [PATCH 3/3] sr: Remove in_interrupt() usage in sr_init_command() Sebastian Andrzej Siewior
2020-12-11 17:09     ` Sebastian Andrzej Siewior [this message]
2020-12-12 18:12 ` [PATCH 0/3] Remove in_interrupt() usage in sr Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211170915.4bs2huyptnsmlwvf@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=a.darwish@linutronix.de \
    --cc=axboe@kernel.dk \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 3/3] sr: Remove in_interrupt() usage in sr_init_command().' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).