From: Jakub Kicinski <firstname.lastname@example.org>
To: Yonatan Linik <email@example.com>
Cc: David Miller <firstname.lastname@example.org>,
Alexei Starovoitov <email@example.com>,
Daniel Borkmann <firstname.lastname@example.org>,
Martin KaFai Lau <email@example.com>, Song Liu <firstname.lastname@example.org>,
Yonghong Song <email@example.com>, Andrii Nakryiko <firstname.lastname@example.org>,
John Fastabend <email@example.com>,
KP Singh <firstname.lastname@example.org>,
Willem de Bruijn <email@example.com>,
firstname.lastname@example.org, Arnd Bergmann <email@example.com>,
Mao Wenan <firstname.lastname@example.org>,
Colin Ian King <email@example.com>,
firstname.lastname@example.org, Networking <email@example.com>,
firstname.lastname@example.org, bpf <email@example.com>
Subject: Re: [PATCH 1/1] net: Fix use of proc_fs
Date: Sat, 12 Dec 2020 13:51:19 -0800 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On Sat, 12 Dec 2020 23:39:20 +0200 Yonatan Linik wrote:
> On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski <email@example.com> wrote:
> > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote:
> > > proc_fs was used, in af_packet, without a surrounding #ifdef,
> > > although there is no hard dependency on proc_fs.
> > > That caused the initialization of the af_packet module to fail
> > > when CONFIG_PROC_FS=n.
> > >
> > > Specifically, proc_create_net() was used in af_packet.c,
> > > and when it fails, packet_net_init() returns -ENOMEM.
> > > It will always fail when the kernel is compiled without proc_fs,
> > > because, proc_create_net() for example always returns NULL.
> > >
> > > The calling order that starts in af_packet.c is as follows:
> > > packet_init()
> > > register_pernet_subsys()
> > > register_pernet_operations()
> > > __register_pernet_operations()
> > > ops_init()
> > > ops->init() (packet_net_ops.init=packet_net_init())
> > > proc_create_net()
> > >
> > > It worked in the past because register_pernet_subsys()'s return value
> > > wasn't checked before this Commit 36096f2f4fa0 ("packet: Fix error path in
> > > packet_init.").
> > > It always returned an error, but was not checked before, so everything
> > > was working even when CONFIG_PROC_FS=n.
> > >
> > > The fix here is simply to add the necessary #ifdef.
> > >
> > > Signed-off-by: Yonatan Linik <firstname.lastname@example.org>
> > Hm, I'm guessing you hit this on a kernel upgrade of a real system?
> Yeah, suddenly using socket with AF_PACKET didn't work,
> so I checked what happened.
> > It seems like all callers to proc_create_net (and friends) interpret
> > NULL as an error, but only handful is protected by an ifdef.
> I guess where there is no ifdef,
> there should be a hard dependency on procfs,
> using depends on in the Kconfig.
> Maybe that's not the case everywhere it should be.
You're right, on a closer look most of the places have a larger #ifdef
block (which my grep didn't catch) or are under Kconfig. Of those I
checked only TLS looks wrong (good job me) - would you care to fix that
one as well, or should I?
> > I checked a few and none of them cares about the proc_dir_entry pointer
> > that gets returned. Should we perhaps rework the return values of the
> > function so that we can return success if !CONFIG_PROC_FS without
> > having to yield a pointer?
> Sometimes the pointer returned is used,
> for example in drivers/acpi/button.c.
> Are you suggesting returning a bool while
> having the pointer as an out parameter?
> Because that would still be problematic where the pointer is used.
Ack, I was only thinking of changing proc_create_net* but as you
rightly pointed out most callers already deal with the problem,
so maybe it's not worth refactoring.
> > Obviously we can apply this fix so we can backport to 5.4 if you need
> > it. I think the ifdef is fine, since it's what other callers have.
> It would be great to apply this where the problem exists,
> I believe this applies to other versions as well.
Will do. Linus is likely to cut the final 5.11 release on Sunday, so
it needs to wait until next week for process reasons but it won't get
lost. For the record:
Fixes: 36096f2f4fa0 ("packet: Fix error path in packet_init")
next prev parent reply other threads:[~2020-12-12 21:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 16:37 [PATCH 0/1] net: Fix use of proc_fs Yonatan Linik
2020-12-11 16:37 ` [PATCH 1/1] " Yonatan Linik
2020-12-11 20:59 ` Arnd Bergmann
2020-12-12 8:39 ` Yonatan Linik
2020-12-12 19:48 ` Jakub Kicinski
2020-12-12 21:39 ` Yonatan Linik
2020-12-12 21:51 ` Jakub Kicinski [this message]
2020-12-13 9:48 ` Yonatan Linik
2020-12-14 19:07 ` Jakub Kicinski
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).