From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B8F8C433FE for ; Sun, 13 Dec 2020 14:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DB0122D57 for ; Sun, 13 Dec 2020 14:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437110AbgLMOLz (ORCPT ); Sun, 13 Dec 2020 09:11:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:37708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395199AbgLMOLL (ORCPT ); Sun, 13 Dec 2020 09:11:11 -0500 Date: Sun, 13 Dec 2020 09:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607868630; bh=S0NZCKTHXO1/XgTBibTeHKY2NyaV+jWp9oZjgvuSOZg=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=nFttyLKxDFdTzDqG+uV+ZMYwIDraCwmT1csa8RGjNQtB2KNQuC3CWvsr8XvQHFTkX bOVfEZ3hZGq/q87besC+Bjzp/UHT9BZ6/avesb9g234GUTyQ6mz9ZdKVWLvvWayKcR 5IsZC3of1cWOok1XpWOR2jKmC5sWYP7UWQbjwfCJNcyT1mEousS3/8Iz7qmQngrF+E UBfwNFX/Xim1w8qNAQxV89tayOf16Xozhta7DOpqMYNyp+n+eIU7Y985xkZoMGJ7UI W/Q6SnFz+H4jXIWSjxGFg8FVH/fANHjQkaleEJRhOabM6QD83DoUX7CgAE554wRsQU Zom91bCLKheaA== From: Sasha Levin To: Peter Zijlstra Cc: Heiko Carstens , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sven Schnelle , Mark Rutland , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Message-ID: <20201213141029.GQ643756@sasha-vm> References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha