From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F86EC2BB48 for ; Mon, 14 Dec 2020 14:19:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52BC122BE9 for ; Mon, 14 Dec 2020 14:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440022AbgLNOSy (ORCPT ); Mon, 14 Dec 2020 09:18:54 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:57632 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439156AbgLNOST (ORCPT ); Mon, 14 Dec 2020 09:18:19 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BEEADvJ071907; Mon, 14 Dec 2020 14:17:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=RHfuFk1oW8oW5MMEI9K9uXKlSZyYVbE3kY1cnzm8N9E=; b=o7iiggxkkeureV3QXraU40ZQW33BybRtmR0YaqUo1RV0tYrdzafoymLlT1+cgYN1AWnx fyFXXb3jK4sxuHspnHSR6xNkpUUiUVn4nphdgmYjXsk/yRnBeZaCazg3g1KmAqi7i+de tM0SbiC/YrhV1/bVCq1qC55UsK+HeBIr5WUVzZ3TbgVc17ejdVDU7KGUmaDfb9ZjMwOU 7zSMqDhwgO2zK1BSdHr4D8QkzrIyRNQzA8MwMI6git5wXsmVt84JjyzLZly1ZDrmmm0B fCZ9SOg2pnPIhzRpeiKCFw5XCxeX2OhNh2k+quFgNKzDCmMeauQhcQXUWV1h1oY89q6E 4A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 35cn9r5cyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Dec 2020 14:17:06 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BEEG59E047210; Mon, 14 Dec 2020 14:17:06 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 35d7sukd71-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Dec 2020 14:17:06 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BEEGtYL021946; Mon, 14 Dec 2020 14:16:56 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 14 Dec 2020 06:16:55 -0800 Date: Mon, 14 Dec 2020 17:16:44 +0300 From: Dan Carpenter To: David Laight Cc: "'Philipp Gerlesberger'" , "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@i4.cs.fau.de" , "gregkh@linuxfoundation.org" , "ij72uhux@stud.informatik.uni-erlangen.de" , "sakari.ailus@linux.intel.com" , "mchehab@kernel.org" , "linux-media@vger.kernel.org" Subject: Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Message-ID: <20201214141644.GF2809@kadam> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> <20201214110156.6152-13-Philipp.Gerlesberger@fau.de> <4eef67d66b0b48feba474906431daa30@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4eef67d66b0b48feba474906431daa30@AcuMS.aculab.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012140100 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 malwarescore=0 priorityscore=1501 phishscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012140099 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2020 at 11:53:04AM +0000, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:02 > > > > Logical continuations should be on the previous line > > > > Co-developed-by: Andrey Khlopkov > > Signed-off-by: Andrey Khlopkov > > Signed-off-by: Philipp Gerlesberger > > --- > > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > index 2f1c2df59f71..7d44070c7114 100644 > > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > @@ -24,8 +24,8 @@ > > *****************************************************************************/ > > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) > > { > > - if (NULL == qhandle || NULL == desc > > - || NULL == desc->cb_elems || NULL == desc->cb_desc) { > > + if (NULL == qhandle || NULL == desc || > > + NULL == desc->cb_elems || NULL == desc->cb_desc) { > > /* Invalid parameters, return error*/ Delete this comment as well. It's pointless. (And the curly braces). > > return -EINVAL; > regards, dan carpenter