From: Rob Herring <robh@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: i2c: dw: cancel mandatory requirements for "#address-cells" and "#size-cells"
Date: Mon, 14 Dec 2020 09:16:30 -0600 [thread overview]
Message-ID: <20201214151630.GA1938499@robh.at.kernel.org> (raw)
In-Reply-To: <20201214124347.2120-2-thunder.leizhen@huawei.com>
On Mon, 14 Dec 2020 20:43:47 +0800, Zhen Lei wrote:
> The "#address-cells" and "#size-cells" are required only when the I2C
> controller has subnodes. However, some I2C controllers defined in
> "arch/arm64/boot/dts/amd/" and "arch/arm64/boot/dts/hisilicon/"
> directories do not have child nodes. So they don't need these two
> properties and don't write them explicitly.
>
> Therefore, setting properties "#address-cells" and "#size-cells" as
> "required" in this yaml file causes the following warnings:
> /root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \
> i2c@f7100000: '#address-cells' is a required property
> /root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \
> i2c@f7100000: '#size-cells' is a required property
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2020-12-14 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 12:43 [PATCH v2 0/1] dt-bindings: i2c: dw: cancel mandatory requirements for "#address-cells" and "#size-cells" Zhen Lei
2020-12-14 12:43 ` [PATCH v2 1/1] " Zhen Lei
2020-12-14 15:16 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214151630.GA1938499@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).