From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75257C4361B for ; Mon, 14 Dec 2020 20:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3745E2168B for ; Mon, 14 Dec 2020 20:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502814AbgLNUH7 (ORCPT ); Mon, 14 Dec 2020 15:07:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502994AbgLNUEZ (ORCPT ); Mon, 14 Dec 2020 15:04:25 -0500 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B878CC0611CA for ; Mon, 14 Dec 2020 12:03:23 -0800 (PST) Received: by mail-pj1-x1043.google.com with SMTP id lj6so5554763pjb.0 for ; Mon, 14 Dec 2020 12:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=id/Q5ao6THistubUC4V3inH2fBZpq87NgTKXp27iujY=; b=Ah7IwggI4z9FHB9YbqLDpj0nCp9uUjVuQkXErTXTYqynlfQmuvYA/CfhxB8gw6N9BC HG67Iq68JFApt8mGenms10a8fNTb5JsuoWXEtogvyqPdZP7FmFkB9ljRwdL4NRpuwzjG M0Bpfdrwg3x31h+drs15tcIqwfjErlthCxte5M7XGlRzs02sCnVvcLOYKhedn8YGB0vE KzlYatfyyvZVCZ2VOypXNWPdCmSDNoTSDYLhI4cHDorUzuAOrqbFJmx8qb3mUHU+ghLD TmzGTf1nHnES3uxiI8qn3B6pkHyELmsBOf6IK5Dn/JaVIaOYWJgIKwlIQRx/g61ecqAx ME3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=id/Q5ao6THistubUC4V3inH2fBZpq87NgTKXp27iujY=; b=Xzib/aFV2YJeE2/7YghtsPFrvHG51BHN2UAGipA7ohyzvFPSrWaeekFkp5sikQMBQE s0i6dE7Xe5I5mmLsxNtkd3QtdedVz9cowRWd53j/brH+dD0sPj3M/+u2caM1Xnoqe4fM 9rjLMO3C1lyRo6t/WbOLXyFzya/9bJs5VNmtTlTAySvYyvRwNyCuBdZ9S8ovxw/v+iSK Hwa9jaU7nvtwEw8Oj61M6c/nI+7rKx0zvWBaZFA4afbwYol4b7OgeH2PYqFZkt7cqyjw w2n6ja9QfOl09E1pUP0z2faB7AfEz5F9awK9CJ69ie95Gmc5k7dSw1Q6OGej+OJclt3t 1LEw== X-Gm-Message-State: AOAM533mc1Mtm0as0MkuJtcVY79VZN+U+RLPRUoPJKPWEGsrMm7z3hX0 Buv+OzEgxKQZbtRDHvrhg92ooQ== X-Google-Smtp-Source: ABdhPJwqXwB839aTHuuRfA5fv8f6XIPiV7G7EQ2SPaHJbY5OdwVed//y4tVkvbHpfUDXRFHMnDxotg== X-Received: by 2002:a17:90b:1294:: with SMTP id fw20mr26654548pjb.187.1607976203320; Mon, 14 Dec 2020 12:03:23 -0800 (PST) Received: from localhost.localdomain ([163.172.76.58]) by smtp.googlemail.com with ESMTPSA id js9sm22434109pjb.2.2020.12.14.12.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 12:03:22 -0800 (PST) From: Corentin Labbe To: arnd@arndb.de, davem@davemloft.net, herbert@gondor.apana.org.au, jernej.skrabec@siol.net, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe , stable@vger.kernel.org Subject: [PATCH v4 5/8] crypto: sun4i-ss: initialize need_fallback Date: Mon, 14 Dec 2020 20:02:29 +0000 Message-Id: <20201214200232.17357-6-clabbe@baylibre.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201214200232.17357-1-clabbe@baylibre.com> References: <20201214200232.17357-1-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The need_fallback is never initialized and seem to be always true at runtime. So all hardware operations are always bypassed. Fixes: 0ae1f46c55f87 ("crypto: sun4i-ss - fallback when length is not multiple of blocksize") Cc: Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c index e097f4c3e68f..5759fa79f293 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c @@ -179,7 +179,7 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) unsigned int obo = 0; /* offset in bufo*/ unsigned int obl = 0; /* length of data in bufo */ unsigned long flags; - bool need_fallback; + bool need_fallback = false; if (!areq->cryptlen) return 0; -- 2.26.2