From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>, Eric Anholt <eric@anholt.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 4/5] amba: Make the remove callback return void
Date: Mon, 14 Dec 2020 21:40:46 +0100 [thread overview]
Message-ID: <20201214204046.xopipytz4ws7j72f@pengutronix.de> (raw)
In-Reply-To: <20201203130141.ys2s7aaltyzkdena@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 3981 bytes --]
On Thu, Dec 03, 2020 at 02:01:41PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> [This is a resend because somehow my MUA failed to parse the To: list
> and dropped it without me noticing it. Sorry to those who got it twice
> now.]
>
> On Tue, Nov 24, 2020 at 02:31:38PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > All amba drivers return 0 in their remove callback. Together with the
> > driver core ignoring the return value anyhow, it doesn't make sense to
> > return a value here.
> >
> > Change the remove prototype to return void, which makes it explicit that
> > returning an error value doesn't work as expected. This simplifies changing
> > the core remove callback to return void, too.
> >
> > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/amba/bus.c | 5 ++---
> > drivers/char/hw_random/nomadik-rng.c | 3 +--
> > drivers/dma/pl330.c | 3 +--
> > drivers/gpu/drm/pl111/pl111_drv.c | 4 +---
> > drivers/hwtracing/coresight/coresight-catu.c | 3 +--
> > drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 +---
> > drivers/hwtracing/coresight/coresight-cti-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-etb10.c | 4 +---
> > drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-funnel.c | 4 ++--
> > drivers/hwtracing/coresight/coresight-replicator.c | 4 ++--
> > drivers/hwtracing/coresight/coresight-stm.c | 4 +---
> > drivers/hwtracing/coresight/coresight-tmc-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-tpiu.c | 4 +---
> > drivers/i2c/busses/i2c-nomadik.c | 4 +---
> > drivers/input/serio/ambakmi.c | 3 +--
> > drivers/memory/pl172.c | 4 +---
> > drivers/memory/pl353-smc.c | 4 +---
> > drivers/mmc/host/mmci.c | 4 +---
> > drivers/rtc/rtc-pl030.c | 4 +---
> > drivers/rtc/rtc-pl031.c | 4 +---
> > drivers/spi/spi-pl022.c | 5 ++---
> > drivers/tty/serial/amba-pl010.c | 4 +---
> > drivers/tty/serial/amba-pl011.c | 3 +--
> > drivers/vfio/platform/vfio_amba.c | 3 +--
> > drivers/video/fbdev/amba-clcd.c | 4 +---
> > drivers/watchdog/sp805_wdt.c | 4 +---
> > include/linux/amba/bus.h | 2 +-
> > sound/arm/aaci.c | 4 +---
> > 30 files changed, 34 insertions(+), 80 deletions(-)
>
> I failed to Cc: the relevant maintainers before, so that's why I'm
> adressing you now. The idea is to let this series (completely available at
> https://lore.kernel.org/linux-arm-kernel/20201124133139.3072124-1-uwe@kleine-koenig.org/)
> go in via Russell King's tree, so an Ack from you would be great. If you
> want the original in your mailbox, just tell me and I can send you a
> bounce (or use b4 on the above link).
Technically there are still some maintainers' ack missing but I'd really
like to get this series applied. As I don't want to make people angry
I'm asking once more for your Acks.
Or is the stuff outside of drivers/amba trivial enough to merge it even
without each maintainer's ack? (It's changing some functions from
returning int to void and dropping "return 0;".)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-14 20:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 13:31 [PATCH v2 0/5] amba: minor fix and various cleanups Uwe Kleine-König
2020-11-24 13:31 ` [PATCH v2 1/5] amba: Fix resource leak for drivers without .remove Uwe Kleine-König
2020-11-24 13:31 ` [PATCH v2 2/5] amba: reorder functions Uwe Kleine-König
2020-11-24 13:31 ` [PATCH v2 3/5] vfio: platform: simplify device removal Uwe Kleine-König
2020-12-02 15:15 ` Auger Eric
2020-11-24 13:31 ` [PATCH v2 4/5] amba: Make the remove callback return void Uwe Kleine-König
2020-12-03 11:53 ` Uwe Kleine-König
2020-12-03 13:01 ` Uwe Kleine-König
2020-12-03 14:11 ` Krzysztof Kozlowski
2020-12-03 14:16 ` Mark Brown
2020-12-03 19:36 ` Dmitry Torokhov
2020-12-14 20:40 ` Uwe Kleine-König [this message]
2020-12-17 10:00 ` Linus Walleij
2020-12-03 13:44 ` Alexandre Belloni
2020-11-24 13:31 ` [PATCH v2 5/5] amba: Make use of bus_type functions Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214204046.xopipytz4ws7j72f@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mpm@selenic.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).