From: Zev Weiss <zev@bewilderbeest.net>
To: Eddie James <eajames@linux.ibm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-media@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Zev Weiss <zev@bewilderbeest.net>,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Subject: [PATCH 1/3] aspeed-video: add error message for unhandled interrupts
Date: Mon, 14 Dec 2020 20:45:40 -0600 [thread overview]
Message-ID: <20201215024542.18888-2-zev@bewilderbeest.net> (raw)
In-Reply-To: <20201215024542.18888-1-zev@bewilderbeest.net>
This device seems to have a propensity for asserting interrupts that
aren't enabled -- in addition to the CAPTURE_COMPLETE and FRAME_COMPLETE
interrupts squashed in commit 65d270acb2d662c3346793663ac3a759eb4491b8,
COMP_READY has also been observed. Adding a message diagnosing what
happened in the event of unhandled interrupt status bits should
hopefully make the debugging process simpler for any others that pop up
in the future.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
drivers/media/platform/aspeed-video.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index 7d98db1d9b52..eb02043532e3 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -562,6 +562,7 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg)
{
struct aspeed_video *video = arg;
u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS);
+ u32 orig_sts = sts;
/*
* Resolution changed or signal was lost; reset the engine and
@@ -639,6 +640,10 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg)
if (sts & VE_INTERRUPT_FRAME_COMPLETE)
sts &= ~VE_INTERRUPT_FRAME_COMPLETE;
+ if (sts)
+ dev_err_ratelimited(video->dev, "unexpected interrupt asserted:"
+ " sts=%08x, orig_sts=%08x", sts, orig_sts);
+
return sts ? IRQ_NONE : IRQ_HANDLED;
}
--
2.29.2
next prev parent reply other threads:[~2020-12-15 2:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 2:45 [PATCH 0/3] aspeed-video: extend spurious interrupt handling Zev Weiss
2020-12-15 2:45 ` Zev Weiss [this message]
2020-12-22 4:34 ` [PATCH 1/3] aspeed-video: add error message for unhandled interrupts Joel Stanley
2020-12-22 19:11 ` Zev Weiss
2020-12-15 2:45 ` [PATCH 2/3] aspeed-video: clear spurious interrupt bits unconditionally Zev Weiss
2020-12-22 4:47 ` Joel Stanley
2020-12-22 19:14 ` Zev Weiss
2020-12-23 1:07 ` Joel Stanley
2020-12-23 2:53 ` Ryan Chen
2020-12-23 3:53 ` Zev Weiss
2020-12-23 5:58 ` Ryan Chen
2020-12-15 2:45 ` [PATCH 3/3] aspeed-video: add COMP_READY to VE_SPURIOUS_IRQS Zev Weiss
2020-12-22 4:49 ` Joel Stanley
2021-03-09 16:43 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215024542.18888-2-zev@bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).