From: Leon Romanovsky <leon@kernel.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] infiniband: core: Delete useless kfree code
Date: Tue, 15 Dec 2020 09:53:17 +0200 [thread overview]
Message-ID: <20201215075317.GM5005@unreal> (raw)
In-Reply-To: <20201214134655.4991-1-zhengyongjun3@huawei.com>
On Mon, Dec 14, 2020 at 09:46:55PM +0800, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/infiniband/core/cma_configfs.c | 1 -
> 1 file changed, 1 deletion(-)
The best thing will be to delete whole "free:" section and return
an error immediately.
Thanks
>
> diff --git a/drivers/infiniband/core/cma_configfs.c b/drivers/infiniband/core/cma_configfs.c
> index 7ec4af2ed87a..c6e7cd9bc25a 100644
> --- a/drivers/infiniband/core/cma_configfs.c
> +++ b/drivers/infiniband/core/cma_configfs.c
> @@ -235,7 +235,6 @@ static int make_cma_ports(struct cma_dev_group *cma_dev_group,
>
> return 0;
> free:
> - kfree(ports);
> cma_dev_group->ports = NULL;
> return err;
> }
> --
> 2.22.0
>
prev parent reply other threads:[~2020-12-15 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 13:46 [PATCH -next] infiniband: core: Delete useless kfree code Zheng Yongjun
2020-12-15 7:53 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215075317.GM5005@unreal \
--to=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).