From: Youghandhar Chintala <youghand@codeaurora.org>
To: johannes@sipsolutions.net
Cc: davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuabhs@chromium.org,
dianders@chromium.org, briannorris@chromium.org,
pillair@codeaurora.org,
Youghandhar Chintala <youghand@codeaurora.org>
Subject: [PATCH 1/3] cfg80211: Add wiphy flag to trigger STA disconnect after hardware restart
Date: Tue, 15 Dec 2020 23:00:21 +0530 [thread overview]
Message-ID: <20201215173021.5884-1-youghand@codeaurora.org> (raw)
Many wifi drivers (e.g. ath10k using qualcomm wifi chipsets)
support silent target hardware restart/recovery. Out of these
drivers which support target hw restart, certain chipsets
have the wifi mac sequence number addition for transmitted
frames done by the firmware. For such chipsets, a silent
target hardware restart breaks the continuity of the wifi
mac sequence number, since the wifi mac sequence number
restarts from 0 after the restart, which in-turn leads
to the peer access point dropping all the frames from device
until it receives the frame with the mac sequence which was
expected by the AP.
Add a wiphy flag for the driver to indicate that it needs a
trigger for STA disconnect after hardware restart.
Tested on ath10k using WCN3990, QCA6174.
Signed-off-by: Youghandhar Chintala <youghand@codeaurora.org>
---
include/net/cfg80211.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index ab249ca..7fba6f6 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -4311,6 +4311,9 @@ struct cfg80211_ops {
* @WIPHY_FLAG_HAS_STATIC_WEP: The device supports static WEP key installation
* before connection.
* @WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK: The device supports bigger kek and kck keys
+ * @WIPHY_FLAG_STA_DISCONNECT_ON_HW_RESTART: The device needs a trigger to
+ * disconnect STA after target hardware restart. This flag should be
+ * exposed by drivers which support target recovery.
*/
enum wiphy_flags {
WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK = BIT(0),
@@ -4337,6 +4340,7 @@ enum wiphy_flags {
WIPHY_FLAG_SUPPORTS_5_10_MHZ = BIT(22),
WIPHY_FLAG_HAS_CHANNEL_SWITCH = BIT(23),
WIPHY_FLAG_HAS_STATIC_WEP = BIT(24),
+ WIPHY_FLAG_STA_DISCONNECT_ON_HW_RESTART = BIT(25),
};
/**
--
2.7.4
next reply other threads:[~2020-12-15 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 17:30 Youghandhar Chintala [this message]
2021-02-05 22:02 ` [PATCH 1/3] cfg80211: Add wiphy flag to trigger STA disconnect after hardware restart Abhishek Kumar
2021-02-12 8:36 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2020-12-15 17:21 Youghandhar Chintala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215173021.5884-1-youghand@codeaurora.org \
--to=youghand@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=kuabhs@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).