From: Jakub Kicinski <kuba@kernel.org>
To: Gao Yan <gao.yanB@h3c.com>
Cc: <paulus@samba.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: remove disc_data_lock in ppp line discipline
Date: Wed, 16 Dec 2020 16:48:38 -0800 [thread overview]
Message-ID: <20201216164838.55f939a2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201215150054.570-1-gao.yanB@h3c.com>
On Tue, 15 Dec 2020 23:00:54 +0800 Gao Yan wrote:
> tty layer provide tty->ldisc_sem lock to protect tty->disc_data;
> For examlpe, when cpu A is running ppp_synctty_ioctl that
> hold the tty->ldisc_sem, so if cpu B calls ppp_synctty_close,
> it will wait until cpu A release tty->ldisc_sem. So I think it is
> unnecessary to have the disc_data_lock;
>
> cpu A cpu B
> tty_ioctl tty_reopen
> ->hold tty->ldisc_sem ->hold tty->ldisc_sem(write), failed
> ->ld->ops->ioctl ->wait...
> ->release tty->ldisc_sem ->wait...OK,hold tty->ldisc_sem
> ->tty_ldisc_reinit
> ->tty_ldisc_close
> ->ld->ops->close
>
> Signed-off-by: Gao Yan <gao.yanB@h3c.com>
# Form letter - net-next is closed
We have already sent the networking pull request for 5.11 and therefore
net-next is closed for new drivers, features, code refactoring and
optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens after 5.11-rc1 is cut.
Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html
RFC patches sent for review only are obviously welcome at any time.
next prev parent reply other threads:[~2020-12-17 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 15:00 [PATCH] net: remove disc_data_lock in ppp line discipline Gao Yan
2020-12-17 0:48 ` Jakub Kicinski [this message]
2020-12-28 7:15 Gao Yan
2021-01-01 1:37 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216164838.55f939a2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gao.yanB@h3c.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).