From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBC1C2BBCF for ; Wed, 16 Dec 2020 18:53:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E957E23407 for ; Wed, 16 Dec 2020 18:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732367AbgLPSxP (ORCPT ); Wed, 16 Dec 2020 13:53:15 -0500 Received: from mx2.suse.de ([195.135.220.15]:45844 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732361AbgLPSxO (ORCPT ); Wed, 16 Dec 2020 13:53:14 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C406AAF0B; Wed, 16 Dec 2020 18:52:32 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id CB5A8DA7B4; Wed, 16 Dec 2020 19:50:52 +0100 (CET) Date: Wed, 16 Dec 2020 19:50:52 +0100 From: David Sterba To: Herbert Xu Cc: Nick Terrell , Eric Biggers , Nick Terrell , "squashfs-devel@lists.sourceforge.net" , Christoph Hellwig , Yann Collet , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Petr Malat , Chris Mason , "linux-crypto@vger.kernel.org" , Kernel Team , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Niket Agarwal , Btrfs BTRFS , Johannes Weiner Subject: Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6 Message-ID: <20201216185052.GL6430@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Herbert Xu , Nick Terrell , Eric Biggers , Nick Terrell , "squashfs-devel@lists.sourceforge.net" , Christoph Hellwig , Yann Collet , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Petr Malat , Chris Mason , "linux-crypto@vger.kernel.org" , Kernel Team , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Niket Agarwal , Btrfs BTRFS , Johannes Weiner References: <20201203205114.1395668-1-nickrterrell@gmail.com> <20201216005806.GA26841@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201216005806.GA26841@gondor.apana.org.au> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2020 at 11:58:07AM +1100, Herbert Xu wrote: > On Wed, Dec 16, 2020 at 12:48:51AM +0000, Nick Terrell wrote: > > > > Thanks for the advice! The first zstd patches went through Herbert’s tree, which is > > why I’ve sent them this way. > > Sorry, but I'm not touch these patches as Christoph's objections > don't seem to have been addressed. I have objections to the current patchset as well, the build bot has found that some of the function frames are overly large (up to 3800 bytes) [1], besides the original complaint that the patch 3/3 is 1.5MiB. [1] https://lore.kernel.org/lkml/20201204140314.GS6430@twin.jikos.cz/