From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Michael Walle <michael@walle.cc>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexandru Marginean <alexandru.marginean@nxp.com>
Subject: Re: [PATCH net-next 2/4] enetc: don't use macro magic for the readx_poll_timeout() callback
Date: Wed, 16 Dec 2020 19:23:53 +0000 [thread overview]
Message-ID: <20201216192352.5kbjxyhpwgmubm76@skbuf> (raw)
In-Reply-To: <20201215212200.30915-3-michael@walle.cc>
On Tue, Dec 15, 2020 at 10:21:58PM +0100, Michael Walle wrote:
> The macro enetc_mdio_rd_reg() is just used in that particular case and
> has a hardcoded parameter name "mdio_priv". Define a specific function
> to use for readx_poll_timeout() instead. Also drop the TIMEOUT macro
> since it is used just once.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2020-12-16 19:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 21:21 [PATCH net-next 0/4] enetc: code cleanups Michael Walle
2020-12-15 21:21 ` [PATCH net-next 1/4] enetc: drop unneeded indirection Michael Walle
2020-12-16 2:31 ` Andrew Lunn
2020-12-16 19:20 ` Vladimir Oltean
2020-12-15 21:21 ` [PATCH net-next 2/4] enetc: don't use macro magic for the readx_poll_timeout() callback Michael Walle
2020-12-16 2:34 ` Andrew Lunn
2020-12-16 19:23 ` Vladimir Oltean [this message]
2020-12-15 21:21 ` [PATCH net-next 3/4] enetc: drop MDIO_DATA() macro Michael Walle
2020-12-16 2:42 ` Andrew Lunn
2020-12-16 19:24 ` Vladimir Oltean
2020-12-15 21:22 ` [PATCH net-next 4/4] enetc: reorder macros and functions Michael Walle
2020-12-16 3:02 ` Andrew Lunn
2020-12-16 19:24 ` Vladimir Oltean
2020-12-16 19:25 ` [PATCH net-next 0/4] enetc: code cleanups Vladimir Oltean
2020-12-16 19:33 ` Michael Walle
2020-12-16 23:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216192352.5kbjxyhpwgmubm76@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=alexandru.marginean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).