From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5211C4361B for ; Thu, 17 Dec 2020 01:24:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51D2B233FB for ; Thu, 17 Dec 2020 01:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388948AbgLQBYP (ORCPT ); Wed, 16 Dec 2020 20:24:15 -0500 Received: from rere.qmqm.pl ([91.227.64.183]:47793 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728191AbgLQBYP (ORCPT ); Wed, 16 Dec 2020 20:24:15 -0500 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4CxDlk0Rxjz63; Thu, 17 Dec 2020 02:23:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1608168212; bh=xW9ibLoV5/qLNGN3Busmpz2Fsg3WeYdpFtrM6aESBL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F0QsVj+LedvuKyx7KZpPQpw/FaclNAFrecY5kvlTJPqc3hYXnLY7op+/R4JKKwzDF ecWxaZk85UXkipmWiu3WwIoa/34ijll1c4Ngi+s3cv69sH0T1McNVJBKLGObCRXzpH Jc5sXYV/LlIoS8hF/K6iOIvo6Ao6HNI661kpnm0A7SSzIMH6G+R8ZIfES4MKDY1r9m YTolpcJL32aBuI62lC7xiIntdYzi+kFihpB5y/tgq/67LV/cyol3x5aVHUxOh+cqLo HQDZEaBtrtIWxCvaz1hyzR5Xvs2NUwWZTjiZDF4cPyy0vuCpkz+K+Qj4lm/PcwXW3R 6vAZMtyNYVphQ== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.4 at mail Date: Thu, 17 Dec 2020 02:23:38 +0100 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Nick Terrell Cc: David Sterba , Herbert Xu , Eric Biggers , Nick Terrell , "squashfs-devel@lists.sourceforge.net" , Christoph Hellwig , Yann Collet , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Petr Malat , Chris Mason , "linux-crypto@vger.kernel.org" , Kernel Team , Niket Agarwal , Btrfs BTRFS , Johannes Weiner Subject: Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6 Message-ID: <20201217012337.GA24705@qmqm.qmqm.pl> References: <20201203205114.1395668-1-nickrterrell@gmail.com> <20201216005806.GA26841@gondor.apana.org.au> <20201216185052.GL6430@twin.jikos.cz> <6C449BCE-E7DB-4EE6-B4F5-FED3977BD8F0@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6C449BCE-E7DB-4EE6-B4F5-FED3977BD8F0@fb.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2020 at 10:07:38PM +0000, Nick Terrell wrote: [...] > It is very large. If it helps, in the commit message I’ve provided this link [0], > which provides the diff between upstream zstd as-is and the imported zstd, > which has been modified by the automated tooling to work in the kernel. > [0] https://github.com/terrelln/linux/commit/ac2ee65dcb7318afe426ad08f6a844faf3aebb41 I looks like you could remove a bit more dead code by noting __GNUC__ >= 4 (gcc-4.9 is currently the oldest supported [1]). [1] Documentation/process/changes.rst Best Regards Michał Mirosław