From: Catalin Marinas <catalin.marinas@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ionela Voinescu <ionela.voinescu@arm.com>,
Will Deacon <will@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/3] arm64: topology: Avoid the have_policy check
Date: Thu, 17 Dec 2020 10:55:25 +0000 [thread overview]
Message-ID: <20201217105524.GA15336@gaia> (raw)
In-Reply-To: <20201217075732.blac5pbca7prmuum@vireshk-i7>
Hi Viresh,
On Thu, Dec 17, 2020 at 01:27:32PM +0530, Viresh Kumar wrote:
> On 15-12-20, 11:04, Viresh Kumar wrote:
> > Every time I have stumbled upon this routine, I get confused with the
> > way 'have_policy' is used and I have to dig in to understand why is it
> > so. Here is an attempt to make it easier to understand, and hopefully it
> > is an improvement.
> >
> > The 'have_policy' check was just an optimization to avoid writing
> > to amu_fie_cpus in case we don't have to, but that optimization itself
> > is creating more confusion than the real work. Lets just do that if all
> > the CPUs support AMUs. It is much cleaner that way.
> >
> > Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > V3:
> > - Added Reviewed by tag.
>
> Catalin, please pick the first two patches for 5.11. I will send the
> last one separately later on.
I haven't figured out whether these are fixes (a cover letter would
help ;)). They look like generic improvements to me and given that we
are already in the 5.11 merging window, they would probably need to wait
until 5.12.
--
Catalin
next prev parent reply other threads:[~2020-12-17 10:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 5:34 [PATCH V3 1/3] arm64: topology: Avoid the have_policy check Viresh Kumar
2020-12-15 5:34 ` [PATCH V3 2/3] arm64: topology: Reorder init_amu_fie() a bit Viresh Kumar
2020-12-15 11:53 ` Ionela Voinescu
2020-12-15 5:34 ` [PATCH V3 3/3] arm64: topology: Make AMUs work with modular cpufreq drivers Viresh Kumar
2020-12-15 11:56 ` Ionela Voinescu
2020-12-16 0:03 ` Ionela Voinescu
2020-12-16 4:38 ` Viresh Kumar
2020-12-16 19:37 ` Ionela Voinescu
2020-12-17 10:50 ` Viresh Kumar
2021-01-08 9:44 ` Ionela Voinescu
2021-01-08 10:42 ` Ionela Voinescu
2021-01-08 11:03 ` Viresh Kumar
2020-12-17 7:57 ` [PATCH V3 1/3] arm64: topology: Avoid the have_policy check Viresh Kumar
2020-12-17 10:55 ` Catalin Marinas [this message]
2020-12-18 4:26 ` Viresh Kumar
2020-12-18 11:01 ` Catalin Marinas
2020-12-18 11:04 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217105524.GA15336@gaia \
--to=catalin.marinas@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).