From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DF3C4361B for ; Thu, 17 Dec 2020 13:00:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85B5D2389E for ; Thu, 17 Dec 2020 13:00:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727227AbgLQNAl (ORCPT ); Thu, 17 Dec 2020 08:00:41 -0500 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:39581 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726601AbgLQNAf (ORCPT ); Thu, 17 Dec 2020 08:00:35 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 8AA567F9; Thu, 17 Dec 2020 07:59:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 17 Dec 2020 07:59:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=nAhVtWrDkd61G5pxUHemYZDSqXG grHNp+6N+yclpKH0=; b=rds139swIOm51os10Z7Gm12FNXY1sy9cOpIaVXYj9+Z FON/+1UMlltUXUld1n9tcrwww8b+uuzchs1jCT0ICfy1YRKFX2j70XTZO0DM+RLk b12p9CqmAfMdEoLfoHhJvC9+RZM1YuecC6tQTudvxiE0f0CzqwKBMN4Bb5Oh99D/ FFPW8JbpBB8Mto5nU7pzJaQUSGvOb2jV5sujQJGY7R6hrg79vHgkSfsA1tmKo/Ib wMDnWYSYCVHFpn4/9CgYkLBpXm2tPIAaokja2Uvul5Ly8X0Jo8OTb5aAa/jHUFRo vkh/acp+CDU7acR11DE+1RBd7yWrZQIsTCI5TEEFMtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nAhVtW rDkd61G5pxUHemYZDSqXGgrHNp+6N+yclpKH0=; b=ChCaOH+AZmvNgQEWgDElWj ZVNGlshYbSFEYBBzv86sF557a8AIqsXzzAxPoIQYIy+yZcGvCLDTewPqCHqedyfY BrsuPWj0GrVFey+ShwxiDs5XcajRNJa0nh/a8zUJg0XecXDKuRvkKMLLTw/BfoXQ DFFkhDON5n1737SqjDygUDjwCtAf2sAul388vtsmP7t+YF8HHUzNRK6dnyg9DvPz vrR6d3Y7xHuztOwL5vATyU6Ezp2yFovyIp7HKZorqsXq7NRSQUzXRidGcxVul2oE 1Q3RR1+aLn39iqJOEHq4UWGJCvYW0ckEMoRM+tLLw0VDRQZ7ohuIWFQV+C7aRqpw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudelgedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepvddvgffhkeefgfdthfekjeduffefheeukeeuffevgedvtddtvdehgeelhfel udetnecuffhomhgrihhnpeigshegrghllhdrnhhlnecukfhppeeltddrkeelrdeikedrje einecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgr gihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 2AAE21080063; Thu, 17 Dec 2020 07:59:24 -0500 (EST) Date: Thu, 17 Dec 2020 13:59:22 +0100 From: Maxime Ripard To: Hans Verkuil Cc: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Jason Cooper , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Marc Zyngier , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Thomas Gleixner , Dave Stevenson , linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711 Message-ID: <20201217125922.bx3wx3dwcl6lojre@gilmour> References: <20201210134648.272857-1-maxime@cerno.tech> <23bdb67a-fb55-42d4-9130-ade1b0396768@xs4all.nl> <20201217104946.srurfmuphqzz4c4w@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4u5pz2ddgui6hzza" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4u5pz2ddgui6hzza Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Hans, On Thu, Dec 17, 2020 at 11:53:42AM +0100, Hans Verkuil wrote: > On 17/12/2020 11:49, Maxime Ripard wrote: > > Hi Hans, > >=20 > > On Wed, Dec 16, 2020 at 01:35:43PM +0100, Hans Verkuil wrote: > >> Hi Maxime, > >> > >> On 10/12/2020 14:46, Maxime Ripard wrote: > >>> Hi, > >>> > >>> Here's a series introducing the CEC support for the BCM2711 found on = the > >>> RaspberryPi4. > >>> > >>> The BCM2711 HDMI controller uses a similar layout for the CEC registe= rs, the > >>> main difference being that the interrupt handling part is now shared = between > >>> both HDMI controllers. > >>> > >>> This series is mainly about fixing a couple of bugs, reworking the dr= iver to > >>> support having two different interrupts, one for each direction, prov= ided by an > >>> external irqchip, and enables the irqchip driver for the controller w= e have. > >>> > >>> This has been tested on an RPi3 and RPi4, but requires the latest fir= mware. > >>> It's is based on the 10 and 12 bpc series. > >> > >> This series looks good to me. Before I give my Acked-by for this serie= s, can you > >> confirm that it is possible to transmit the Image View On message on b= oth outputs > >> of the RPi4 when the HPD is low? > >> > >> See section "CEC Without HPD" in https://hverkuil.home.xs4all.nl/cec-s= tatus.txt > >> on how to test this with a Pulse-Eight device. > >> > >> This should work. > >=20 > > This is the output on the RPi4: > >=20 > > # cec-ctl --playback > > Driver Info: > > Driver Name : vc4_hdmi > > Adapter Name : vc4 > > Capabilities : 0x0000010e > > Logical Addresses > > Transmit > > Passthrough > > Driver version : 5.10.0 > > Available Logical Addresses: 1 > > Physical Address : f.f.f.f > > Logical Address Mask : 0x0000 > > CEC Version : 2.0 > > Vendor ID : 0x000c03 (HDMI) > > OSD Name : Playback > > Logical Addresses : 1 (Allow RC Passthrough) > >=20 > > Logical Address : Not Allocated > > Primary Device Type : Playback > > Logical Address Type : Playback > > All Device Types : Playback > > RC TV Profile : None > > Device Features : > > None > >=20 > > # cec-ctl -t0 --image-view-on > > Driver Info: > > Driver Name : vc4_hdmi > > Adapter Name : vc4 > > Capabilities : 0x0000010e > > Logical Addresses > > Transmit > > Passthrough > > Driver version : 5.10.0 > > Available Logical Addresses: 1 > > Physical Address : f.f.f.f > > Logical Address Mask : 0x0000 > > CEC Version : 2.0 > > Vendor ID : 0x000c03 (HDMI) > > OSD Name : Playback > > Logical Addresses : 1 (Allow RC Passthrough) > >=20 > > Logical Address : Not Allocated > > Primary Device Type : Playback > > Logical Address Type : Playback > > All Device Types : Playback > > RC TV Profile : None > > Device Features : > > None > >=20 > >=20 > > Transmit from Unregistered to TV (15 to 0): > > CEC_MSG_IMAGE_VIEW_ON (0x04) > > Sequence: 1 Tx Timestamp: 77.631s > >=20 > >=20 > > And this is the output on my desktop with the Pulse-Eight: > > $ sudo cec-ctl -p0.0.0.0 --tv > > Driver Info: > > Driver Name : pulse8-cec > > Adapter Name : serio0 > > Capabilities : 0x0000003f > > Physical Address > > Logical Addresses > > Transmit > > Passthrough > > Remote Control Support > > Monitor All > > Driver version : 5.9.8 > > Available Logical Addresses: 1 > > Connector Info : None > > Physical Address : 0.0.0.0 > > Logical Address Mask : 0x0001 > > CEC Version : 2.0 > > Vendor ID : 0x000c03 (HDMI) > > OSD Name : 'TV ' > > Logical Addresses : 1 (Allow RC Passthrough) > >=20 > > Logical Address : 0 (TV) > > Primary Device Type : TV > > Logical Address Type : TV > > All Device Types : TV > > RC TV Profile : None > > Device Features : > > None > >=20 > > $ sudo cec-ctl -M > > Driver Info: > > Driver Name : pulse8-cec > > Adapter Name : serio0 > > Capabilities : 0x0000003f > > Physical Address > > Logical Addresses > > Transmit > > Passthrough > > Remote Control Support > > Monitor All > > Driver version : 5.9.8 > > Available Logical Addresses: 1 > > Connector Info : None > > Physical Address : 0.0.0.0 > > Logical Address Mask : 0x0001 > > CEC Version : 2.0 > > Vendor ID : 0x000c03 (HDMI) > > OSD Name : 'TV ' > > Logical Addresses : 1 (Allow RC Passthrough) > >=20 > > Logical Address : 0 (TV) > > Primary Device Type : TV > > Logical Address Type : TV > > All Device Types : TV > > RC TV Profile : None > > Device Features : > > None > >=20 > >=20 > >=20 > > Initial Event: State Change: PA: 0.0.0.0, LA mask: 0x0001, Conn Info: no > > Received from Unregistered to TV (15 to 0): IMAGE_VIEW_ON (0x04) > >=20 > > So it looks like it's working as expected? >=20 > Yes, it looks good. Make sure you test this for both outputs of the RPi4. It's a good thing you asked, I don't appear to get CEC interrupts from HDMI1. I'll fix it and send another version (probably not before the end of december though). > If it works for both, then you can add my >=20 > Acked-by: Hans Verkuil >=20 > for this series. >=20 > Very nice work, thank you for doing this! Thanks! I'll hold your a-b until the next version though, fixing hdmi1 might change a few things. Maxime --4u5pz2ddgui6hzza Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9tWKgAKCRDj7w1vZxhR xVdvAQDHuSRkKxYlgj3+2EqQTksC/VHwJz4gK9OkV9xSfhloJQEA1zz9IR3RFXAN SWKYX8zarHyj+PLw8tW6ddst/1rk+A0= =49ci -----END PGP SIGNATURE----- --4u5pz2ddgui6hzza--