From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2ABCC2BBD4 for ; Fri, 18 Dec 2020 07:13:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF16B23A23 for ; Fri, 18 Dec 2020 07:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732927AbgLRHNl (ORCPT ); Fri, 18 Dec 2020 02:13:41 -0500 Received: from muru.com ([72.249.23.125]:39372 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbgLRHNk (ORCPT ); Fri, 18 Dec 2020 02:13:40 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 32D73809F; Fri, 18 Dec 2020 07:13:01 +0000 (UTC) Date: Fri, 18 Dec 2020 09:12:55 +0200 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Andreas Kemnade , stable@vger.kernel.org Subject: Re: [PATCH] DTS: ARM: gta04: remove legacy spi-cs-high to make display work again Message-ID: <20201218071255.GD26857@atomide.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [201212 11:59]: > This reverts > > commit f1f028ff89cb ("DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again") > > which had to be intruduced after > > commit 6953c57ab172 ("gpio: of: Handle SPI chipselect legacy bindings") > > broke the GTA04 display. This contradicted the data sheet but was the only > way to get it as an spi client operational again. > > The panel data sheet defines the chip-select to be active low. > > Now, with the arrival of > > commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") > > the logic of interaction between spi-cs-high and the gpio descriptor flags > has been changed a second time, making the display broken again. So we have > to remove the original fix which in retrospect was a workaround of a bug in > the spi subsystem and not a feature of the panel or bug in the device tree. > > With this fix the device tree is back in sync with the data sheet and > spi subsystem code. Thanks applying into fixes. Tony