From: mark gross <mgross@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: mgross@linux.intel.com, markgross@kernel.org, arnd@arndb.de,
bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
gregkh@linuxfoundation.org, corbet@lwn.net,
leonard.crestez@nxp.com, palmerdabbelt@google.com,
paul.walmsley@sifive.com, peng.fan@nxp.com, robh+dt@kernel.org,
shawnguo@kernel.org, linux-kernel@vger.kernel.org,
Srikanth Thokala <srikanth.thokala@intel.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 06/22] misc: xlink-pcie: Add documentation for XLink PCIe driver
Date: Fri, 18 Dec 2020 16:07:30 -0800 [thread overview]
Message-ID: <20201219000730.GA37040@linux.intel.com> (raw)
In-Reply-To: <2fd73da0-ee89-3831-bf96-5ed130e90c4d@infradead.org>
On Fri, Dec 18, 2020 at 02:59:00PM -0800, Randy Dunlap wrote:
> On 12/1/20 2:34 PM, mgross@linux.intel.com wrote:
> > From: Srikanth Thokala <srikanth.thokala@intel.com>
> >
> > Provide overview of XLink PCIe driver implementation
> >
> > Cc: linux-doc@vger.kernel.org
> > Reviewed-by: Mark Gross <mgross@linux.intel.com>
> > Signed-off-by: Srikanth Thokala <srikanth.thokala@intel.com>
> > ---
> > Documentation/vpu/index.rst | 1 +
> > Documentation/vpu/xlink-pcie.rst | 91 ++++++++++++++++++++++++++++++++
> > 2 files changed, 92 insertions(+)
> > create mode 100644 Documentation/vpu/xlink-pcie.rst
> >
>
> Hi--
>
> For document, chapter, section, etc., headings, please read & use
> Documentation/doc-guide/sphinx.rst:
>
> * Please stick to this order of heading adornments:
>
> 1. ``=`` with overline for document title::
>
> ==============
> Document title
> ==============
>
> 2. ``=`` for chapters::
>
> Chapters
> ========
>
> 3. ``-`` for sections::
>
> Section
> -------
>
> 4. ``~`` for subsections::
>
> Subsection
> ~~~~~~~~~~
Thanks for the help! I'm new to the sphix markup language and appreciate your
advice. I'll reread that doc-guide.
We'll address the issues on our next posting once the marge window closes.
thanks again for the reviews!
--mark
>
> > diff --git a/Documentation/vpu/xlink-pcie.rst b/Documentation/vpu/xlink-pcie.rst
> > new file mode 100644
> > index 000000000000..bc64b566989d
> > --- /dev/null
> > +++ b/Documentation/vpu/xlink-pcie.rst
> > @@ -0,0 +1,91 @@
> > +.. SPDX-License-Identifier: GPL-2.0-only
> > +
> > +Kernel driver: xlink-pcie driver
> > +================================
> > +Supported chips:
> > + * Intel Edge.AI Computer Vision platforms: Keem Bay
> > + Suffix: Bay
> > + Slave address: 6240
> > + Datasheet: Publicly available at Intel
> > +
> > +Author: Srikanth Thokala Srikanth.Thokala@intel.com
> > +
> > +-------------
> > +Introduction:
>
> No colon at end of chapter/section headings.
>
> > +-------------
> > +The xlink-pcie driver in linux-5.4 provides transport layer implementation for
>
> Linux 5.4 (?)
>
> > +the data transfers to support xlink protocol subsystem communication with the
>
> Xlink
>
> > +peer device. i.e, between remote host system and the local Keem Bay device.
>
> device, i.e., between the remote host system and
>
> > +
> > +The Keem Bay device is an ARM based SOC that includes a vision processing
>
> ARM-based
>
> > +unit (VPU) and deep learning, neural network core in the hardware.
> > +The xlink-pcie driver exports a functional device endpoint to the Keem Bay device
> > +and supports two-way communication with peer device.
>
> with the peer device.
>
> > +
> > +------------------------
> > +High-level architecture:
> > +------------------------
> > +Remote Host: IA CPU
> > +Local Host: ARM CPU (Keem Bay)::
> > +
> > + +------------------------------------------------------------------------+
> > + | Remote Host IA CPU | | Local Host ARM CPU (Keem Bay) | |
> > + +==================================+=+===============================+===+
> > + | User App | | User App | |
> > + +----------------------------------+-+-------------------------------+---+
> > + | XLink UAPI | | XLink UAPI | |
> > + +----------------------------------+-+-------------------------------+---+
> > + | XLink Core | | XLink Core | |
> > + +----------------------------------+-+-------------------------------+---+
> > + | XLink PCIe | | XLink PCIe | |
> > + +----------------------------------+-+-------------------------------+---+
> > + | XLink-PCIe Remote Host driver | | XLink-PCIe Local Host driver | |
> > + +----------------------------------+-+-------------------------------+---+
> > + |-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:|:|:-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:|
> > + +----------------------------------+-+-------------------------------+---+
> > + | PCIe Host Controller | | PCIe Device Controller | HW|
> > + +----------------------------------+-+-------------------------------+---+
> > + ^ ^
> > + | |
> > + |------------- PCIe x2 Link -----------------|
> > +
> > +This XLink PCIe driver comprises of two variants:
> > +* Local Host driver
> > +
> > + * Intended for ARM CPU
> > + * It is based on PCI Endpoint Framework
> > + * Driver path: {tree}/drivers/misc/xlink-pcie/local_host
> > +
> > +* Remote Host driver
> > +
> > + * Intended for IA CPU
> > + * It is a PCIe endpoint driver
> > + * Driver path: {tree}/drivers/misc/xlink-pcie/remote_host
> > +
> > +XLink PCIe communication between local host and remote host is achieved through
> > +ring buffer management and MSI/Doorbell interrupts.
> > +
> > +The xlink-pcie driver subsystem registers Keem Bay device as an endpoint driver
>
> registers the
>
> > +and provides standard linux pcie sysfs interface, # /sys/bus/pci/devices/xxxx:xx:xx.0/
>
> Linux PCIe
>
> > +
> > +
> > +-------------------------
> > +XLink protocol subsystem:
>
> No colon at end.
>
> > +-------------------------
> > +xlink is an abstracted control and communication subsystem based on channel
>
> Xlink
>
> > +identification. It is intended to support VPU technology both at SoC level as
> > +well as at IP level, over multiple interfaces.
> > +
> > +- The xlink subsystem abstracts several types of communication channels
>
> Xlink
>
> > + underneath, allowing the usage of different interfaces with the
> > + same function call interface.
> > +- The Communication channels are full-duplex protocol channels allowing
> > + concurrent bidirectional communication.
> > +- The xlink subsystem also supports control operations to VPU either
>
> Xlink
>
> > + from standalone local system or from remote system based on communication
> > + interface underneath.
> > +- The xlink subsystem supports following communication interfaces:
>
> Xlink supports the following
>
>
> > + * USB CDC
> > + * Gigabit Ethernet
> > + * PCIe
> > + * IPC
> >
>
>
> cheers.
> --
> ~Randy
>
next prev parent reply other threads:[~2020-12-19 0:09 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 22:34 [PATCH 00/22] Intel Vision Processing Unit base enabling part 1 mgross
2020-12-01 22:34 ` [PATCH 01/22] Add Vision Processing Unit (VPU) documentation mgross
2020-12-18 23:30 ` Randy Dunlap
2021-01-07 20:16 ` mark gross
2020-12-01 22:34 ` [PATCH 02/22] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2020-12-07 16:01 ` Rob Herring
2020-12-07 18:22 ` mark gross
2020-12-07 18:42 ` Daniele Alessandrelli
2020-12-07 20:31 ` Jassi Brar
2020-12-09 0:12 ` mark gross
2020-12-09 16:49 ` Jassi Brar
2020-12-09 17:33 ` Rob Herring
2020-12-01 22:34 ` [PATCH 03/22] keembay-ipc: Add Keem Bay IPC module mgross
2020-12-02 6:16 ` Greg KH
2020-12-02 17:42 ` mark gross
2020-12-02 19:01 ` Greg KH
2020-12-05 3:35 ` mark gross
2020-12-05 8:40 ` Greg KH
2020-12-05 16:37 ` Gross, Mark
2020-12-07 1:36 ` mark gross
2020-12-02 6:19 ` Greg KH
2020-12-08 18:59 ` Daniele Alessandrelli
2020-12-08 19:48 ` Greg KH
2020-12-10 18:38 ` Daniele Alessandrelli
2020-12-11 8:22 ` Greg KH
2020-12-11 17:26 ` Gross, Mark
2020-12-01 22:34 ` [PATCH 04/22] dt-bindings: Add bindings for Keem Bay VPU IPC driver mgross
2020-12-07 15:57 ` Rob Herring
2020-12-07 21:28 ` mark gross
2020-12-01 22:34 ` [PATCH 05/22] keembay-vpu-ipc: Add Keem Bay VPU IPC module mgross
2020-12-01 22:34 ` [PATCH 06/22] misc: xlink-pcie: Add documentation for XLink PCIe driver mgross
2020-12-18 22:59 ` Randy Dunlap
2020-12-19 0:07 ` mark gross [this message]
2020-12-01 22:34 ` [PATCH 07/22] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host mgross
2020-12-01 22:34 ` [PATCH 08/22] misc: xlink-pcie: lh: Add PCIe EP DMA functionality mgross
2020-12-01 22:34 ` [PATCH 09/22] misc: xlink-pcie: lh: Add core communication logic mgross
2020-12-02 6:18 ` Greg KH
2020-12-02 16:46 ` Thokala, Srikanth
2020-12-01 22:34 ` [PATCH 10/22] misc: xlink-pcie: lh: Prepare changes for adding remote host driver mgross
2020-12-01 22:35 ` [PATCH 11/22] misc: xlink-pcie: rh: Add PCIe EP driver for Remote Host mgross
2020-12-01 22:35 ` [PATCH 12/22] misc: xlink-pcie: rh: Add core communication logic mgross
2020-12-01 22:35 ` [PATCH 13/22] misc: xlink-pcie: Add XLink API interface mgross
2020-12-01 22:35 ` [PATCH 14/22] misc: xlink-pcie: Add asynchronous event notification support for XLink mgross
2020-12-01 22:35 ` [PATCH 15/22] xlink-ipc: Add xlink ipc device tree bindings mgross
2020-12-07 15:58 ` Rob Herring
2020-12-07 21:41 ` mark gross
2020-12-01 22:35 ` [PATCH 16/22] xlink-ipc: Add xlink ipc driver mgross
2020-12-07 2:32 ` Joe Perches
2020-12-11 11:33 ` Kelly, Seamus
2020-12-11 12:14 ` gregkh
2020-12-11 17:12 ` Gross, Mark
2020-12-07 19:53 ` Randy Dunlap
2020-12-01 22:35 ` [PATCH 17/22] xlink-core: Add xlink core device tree bindings mgross
2020-12-07 16:02 ` Rob Herring
2020-12-01 22:35 ` [PATCH 18/22] xlink-core: Add xlink core driver xLink mgross
2020-12-07 21:50 ` Randy Dunlap
2020-12-01 22:35 ` [PATCH 19/22] xlink-core: Enable xlink protocol over pcie mgross
2020-12-01 22:35 ` [PATCH 20/22] xlink-core: Enable VPU IP management and runtime control mgross
2020-12-01 22:35 ` [PATCH 21/22] xlink-core: add async channel and events mgross
2020-12-07 2:55 ` Joe Perches
2020-12-11 11:34 ` Kelly, Seamus
2020-12-01 22:35 ` [PATCH 22/22] xlink-core: factorize xlink_ioctl function by creating sub-functions for each ioctl command mgross
2020-12-07 3:05 ` Joe Perches
2020-12-07 21:59 ` mark gross
2020-12-09 8:30 ` Joe Perches
2020-12-11 11:36 ` Kelly, Seamus
-- strict thread matches above, loose matches on Subject: below --
2020-11-30 23:06 [PATCH 00/22] Intel Vision Processing Unit base enabling part 1 mgross
2020-11-30 23:06 ` [PATCH 06/22] misc: xlink-pcie: Add documentation for XLink PCIe driver mgross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219000730.GA37040@linux.intel.com \
--to=mgross@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=peng.fan@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=srikanth.thokala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).