linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: <stefanc@marvell.com>
Cc: <netdev@vger.kernel.org>, <thomas.petazzoni@bootlin.com>,
	<davem@davemloft.net>, <nadavh@marvell.com>,
	<ymarkman@marvell.com>, <linux-kernel@vger.kernel.org>,
	<linux@armlinux.org.uk>, <mw@semihalf.com>, <andrew@lunn.ch>,
	<rmk+kernel@armlinux.org.uk>, <stable@vger.kernel.org>
Subject: Re: [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations
Date: Sat, 19 Dec 2020 09:59:17 -0800	[thread overview]
Message-ID: <20201219095917.67401234@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1608208648-13710-1-git-send-email-stefanc@marvell.com>

On Thu, 17 Dec 2020 14:37:28 +0200 stefanc@marvell.com wrote:
> From: Stefan Chulski <stefanc@marvell.com>
> 
> During GoP port 2 Networking Complex Control mode of operation configurations,
> also GoP port 3 mode of operation was wrongly set.
> Patch removes these configurations.
> GENCONF_CTRL0_PORTX naming also fixed.

Testing the stable backport it looks like this addition change will be
problematic. Not to mention it goes against the "fixes should be
minimal" rule.

Could you please send just a one liner which removes the offending
ORing in of the bad bit?

We can do the rename soon after in net-next, the trees are merged
pretty much every week so it won't be a long wait.

> Cc: stable@vger.kernel.org
> Fixes: f84bf386f395 ("net: mvpp2: initialize the GoP")
> Signed-off-by: Stefan Chulski <stefanc@marvell.com>

  parent reply	other threads:[~2020-12-19 18:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 12:37 [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations stefanc
2020-12-18  3:34 ` Marcin Wojtas
2020-12-19 17:59 ` Jakub Kicinski [this message]
2020-12-20 10:49   ` [EXT] " Stefan Chulski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201219095917.67401234@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=stable@vger.kernel.org \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).