From: Nick Desaulniers <ndesaulniers@google.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fs: binfmt_em86: check return code of remove_arg_zero
Date: Tue, 22 Dec 2020 13:03:45 -0800 [thread overview]
Message-ID: <20201222210345.2275038-1-ndesaulniers@google.com> (raw)
In-Reply-To: <55261f67-deb5-4089-5548-62bc091016ec@roeck-us.net>
remove_arg_zero is declared as __must_check. Looks like it can return
-EFAULT on failure.
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
fs/binfmt_em86.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c
index 06b9b9fddf70..6e98fcfca66e 100644
--- a/fs/binfmt_em86.c
+++ b/fs/binfmt_em86.c
@@ -63,7 +63,8 @@ static int load_em86(struct linux_binprm *bprm)
* This is done in reverse order, because of how the
* user environment and arguments are stored.
*/
- remove_arg_zero(bprm);
+ retval = remove_arg_zero(bprm);
+ if (retval < 0) return retval;
retval = copy_string_kernel(bprm->filename, bprm);
if (retval < 0) return retval;
bprm->argc++;
--
2.29.2.729.g45daf8777d-goog
next prev parent reply other threads:[~2020-12-22 21:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 19:33 [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK Masahiro Yamada
2020-11-30 1:04 ` Nathan Chancellor
2020-11-30 18:16 ` Nick Desaulniers
2020-12-02 12:50 ` Miguel Ojeda
2020-12-12 16:18 ` Guenter Roeck
2020-12-13 5:04 ` Miguel Ojeda
2020-12-13 12:55 ` Guenter Roeck
2020-12-13 14:58 ` Miguel Ojeda
2020-12-13 15:16 ` Greg KH
2020-12-13 15:27 ` Miguel Ojeda
2020-12-21 6:18 ` Masahiro Yamada
2020-12-21 10:02 ` Guenter Roeck
2020-12-21 13:51 ` Miguel Ojeda
2020-12-22 21:03 ` Nick Desaulniers [this message]
2021-01-06 2:57 ` [PATCH] fs: binfmt_em86: check return code of remove_arg_zero Miguel Ojeda
2020-12-21 13:51 ` [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK Miguel Ojeda
2020-12-13 15:37 ` Matthias Urlichs
2020-12-13 16:32 ` Miguel Ojeda
2020-12-22 20:54 ` [PATCH] sh: check return code of request_irq Nick Desaulniers
2020-12-23 6:33 ` Masahiro Yamada
2021-01-01 13:50 ` John Paul Adrian Glaubitz
2021-01-01 20:42 ` Miguel Ojeda
2021-01-18 19:00 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222210345.2275038-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).