linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe
Date: Wed, 23 Dec 2020 16:33:04 +0100	[thread overview]
Message-ID: <20201223153304.GD3198262@lunn.ch> (raw)
In-Reply-To: <20201223110615.31389-1-dinghao.liu@zju.edu.cn>

On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote:
> When mdiobus_register() fails, priv->mdio allocated
> by mdiobus_alloc() has not been freed, which leads
> to memleak.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

Fixes: bfa49cfc5262 ("net/ethoc: fix null dereference on error exit path")

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2020-12-23 15:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 11:06 [PATCH] net: ethernet: Fix memleak in ethoc_probe Dinghao Liu
2020-12-23 15:33 ` Andrew Lunn [this message]
2020-12-23 20:32   ` Jakub Kicinski
2020-12-23 21:00     ` Andrew Lunn
2020-12-23 21:11       ` Jakub Kicinski
2020-12-23 22:17         ` Florian Fainelli
2020-12-24  1:41           ` Jakub Kicinski
2020-12-24 18:06             ` Konstantin Ryabitsev
2020-12-24 21:57               ` Florian Fainelli
2020-12-28 20:23                 ` Konstantin Ryabitsev
2020-12-28 21:05                   ` Florian Fainelli
2020-12-28 21:14                     ` Konstantin Ryabitsev
2020-12-30 21:36                       ` Jakub Kicinski
2021-01-06 10:56                         ` dinghao.liu
2021-01-06 16:44                           ` Jakub Kicinski
2021-01-07  7:54                             ` dinghao.liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201223153304.GD3198262@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=dinghao.liu@zju.edu.cn \
    --cc=jesse.brandeburg@intel.com \
    --cc=kjlu@umn.edu \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).