From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3115C433E0 for ; Sat, 26 Dec 2020 12:16:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4DFC221E2 for ; Sat, 26 Dec 2020 12:16:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbgLZMQg (ORCPT ); Sat, 26 Dec 2020 07:16:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgLZMQf (ORCPT ); Sat, 26 Dec 2020 07:16:35 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F31EEC061757 for ; Sat, 26 Dec 2020 04:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QsnqwKrC8FAcmq1cPPiwc8IugCbcu9GsR0MUxmjHSGc=; b=GdsHm/xW8/6Or4SUsT5v5JOxj y7i8GCvXKGSuURt+XikaaV1zLN6oO4DvubALaS+xnIKWi2LuyhDOxXLqlyMYaTrLPxEznYRE5/ooL vq7xoTAJZQ7wKj2VMvjH+IZcACEtLvuA2rdEqQNSvC2jl4ZAfx/eC0dHhfU42B+Km3S6N1dr1QExp brh+rTrjA1girapFm+olYCAGamIYoVmWDSTkilFheGxBFLymjF5MtsH6HMnk/WQdWvvyvP1mlvUzO PucnDRtpwP+WpWQvBdOM0ZFxw2kPvfywCDh5AEOlql89M2VSSe2mrjAgxoiEAE4aOBBJZaF0lT65W D/66iXr3A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44538) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt8U8-0003R4-71; Sat, 26 Dec 2020 12:15:48 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kt8U7-0006pi-Mc; Sat, 26 Dec 2020 12:15:47 +0000 Date: Sat, 26 Dec 2020 12:15:47 +0000 From: Russell King - ARM Linux admin To: "Leizhen (ThunderTown)" Cc: Greg Kroah-Hartman , Will Deacon , Jason Cooper , Haojian Zhuang , Arnd Bergmann , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 1/1] ARM: LPAE: use phys_addr_t instead of unsigned long in outercache hooks Message-ID: <20201226121547.GC1551@shell.armlinux.org.uk> References: <20201225114458.1334-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 26, 2020 at 10:18:08AM +0800, Leizhen (ThunderTown) wrote: > On 2020/12/25 19:44, Zhen Lei wrote: > > The outercache of some Hisilicon SOCs support physical addresses wider > > than 32-bits. The unsigned long datatype is not sufficient for mapping > > physical addresses >= 4GB. The commit ad6b9c9d78b9 ("ARM: 6671/1: LPAE: > > use phys_addr_t instead of unsigned long in outercache functions") has > > already modified the outercache functions. But the parameters of the > > outercache hooks are not changed. This patch use phys_addr_t instead of > > unsigned long in outercache hooks: inv_range, clean_range, flush_range. > > > > To ensure the outercache that does not support LPAE works properly, do > > cast phys_addr_t to unsigned long by adding a middle-tier function. > > This patch will impact the outercache drivers that have not been merged into > the kernel. They should also update the datatype of the outercache hooks. This isn't much of a concern to mainline. If it's that big a problem for you, then please consider merging your code into mainline so that everyone can benefit from it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!