From: kernel test robot <lkp@intel.com>
To: Alex Elder <elder@linaro.org>, davem@davemloft.net, kuba@kernel.org
Cc: kbuild-all@lists.01.org, evgreen@chromium.org,
cpratapa@codeaurora.org, bjorn.andersson@linaro.org,
subashab@codeaurora.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/3] net: ipa: use state to determine channel command success
Date: Sun, 27 Dec 2020 02:51:07 +0800 [thread overview]
Message-ID: <202012270214.QSf8qfSp-lkp@intel.com> (raw)
In-Reply-To: <20201222180012.22489-3-elder@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 4502 bytes --]
Hi Alex,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Alex-Elder/net-ipa-GSI-interrupt-handling-fixes/20201223-020409
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2575bc1aa9d52a62342b57a0b7d0a12146cf6aed
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4073b68cee8a9d0dbb83080db22255fc9b9d7fd5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alex-Elder/net-ipa-GSI-interrupt-handling-fixes/20201223-020409
git checkout 4073b68cee8a9d0dbb83080db22255fc9b9d7fd5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ipa/gsi.c: In function 'gsi_channel_alloc_command':
>> drivers/net/ipa/gsi.c:496:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
496 | int ret;
| ^~~
drivers/net/ipa/gsi.c: In function 'gsi_channel_start_command':
drivers/net/ipa/gsi.c:524:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
524 | int ret;
| ^~~
drivers/net/ipa/gsi.c: In function 'gsi_channel_stop_command':
drivers/net/ipa/gsi.c:552:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
552 | int ret;
| ^~~
drivers/net/ipa/gsi.c: In function 'gsi_channel_reset_command':
drivers/net/ipa/gsi.c:591:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
591 | int ret;
| ^~~
drivers/net/ipa/gsi.c: In function 'gsi_channel_de_alloc_command':
drivers/net/ipa/gsi.c:620:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
620 | int ret;
| ^~~
vim +/ret +496 drivers/net/ipa/gsi.c
650d1603825d8ba Alex Elder 2020-03-05 489
650d1603825d8ba Alex Elder 2020-03-05 490 /* Allocate GSI channel in NOT_ALLOCATED state */
650d1603825d8ba Alex Elder 2020-03-05 491 static int gsi_channel_alloc_command(struct gsi *gsi, u32 channel_id)
650d1603825d8ba Alex Elder 2020-03-05 492 {
650d1603825d8ba Alex Elder 2020-03-05 493 struct gsi_channel *channel = &gsi->channel[channel_id];
a442b3c7554898f Alex Elder 2020-06-30 494 struct device *dev = gsi->dev;
a2003b303875b41 Alex Elder 2020-04-30 495 enum gsi_channel_state state;
650d1603825d8ba Alex Elder 2020-03-05 @496 int ret;
650d1603825d8ba Alex Elder 2020-03-05 497
650d1603825d8ba Alex Elder 2020-03-05 498 /* Get initial channel state */
a2003b303875b41 Alex Elder 2020-04-30 499 state = gsi_channel_state(channel);
a442b3c7554898f Alex Elder 2020-06-30 500 if (state != GSI_CHANNEL_STATE_NOT_ALLOCATED) {
f8d3bdd561a7c95 Alex Elder 2020-11-19 501 dev_err(dev, "channel %u bad state %u before alloc\n",
f8d3bdd561a7c95 Alex Elder 2020-11-19 502 channel_id, state);
650d1603825d8ba Alex Elder 2020-03-05 503 return -EINVAL;
a442b3c7554898f Alex Elder 2020-06-30 504 }
650d1603825d8ba Alex Elder 2020-03-05 505
650d1603825d8ba Alex Elder 2020-03-05 506 ret = gsi_channel_command(channel, GSI_CH_ALLOCATE);
a2003b303875b41 Alex Elder 2020-04-30 507
4073b68cee8a9d0 Alex Elder 2020-12-22 508 /* If successful the channel state will have changed */
a2003b303875b41 Alex Elder 2020-04-30 509 state = gsi_channel_state(channel);
4073b68cee8a9d0 Alex Elder 2020-12-22 510 if (state == GSI_CHANNEL_STATE_ALLOCATED)
4073b68cee8a9d0 Alex Elder 2020-12-22 511 return 0;
4073b68cee8a9d0 Alex Elder 2020-12-22 512
f8d3bdd561a7c95 Alex Elder 2020-11-19 513 dev_err(dev, "channel %u bad state %u after alloc\n",
f8d3bdd561a7c95 Alex Elder 2020-11-19 514 channel_id, state);
650d1603825d8ba Alex Elder 2020-03-05 515
4073b68cee8a9d0 Alex Elder 2020-12-22 516 return -EIO;
650d1603825d8ba Alex Elder 2020-03-05 517 }
650d1603825d8ba Alex Elder 2020-03-05 518
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 76283 bytes --]
next prev parent reply other threads:[~2020-12-26 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 18:00 [PATCH net 0/3] net: ipa: GSI interrupt handling fixes Alex Elder
2020-12-22 18:00 ` [PATCH net 1/3] net: ipa: clear pending interrupts before enabling Alex Elder
2020-12-22 18:00 ` [PATCH net 2/3] net: ipa: use state to determine channel command success Alex Elder
2020-12-26 18:51 ` kernel test robot [this message]
2020-12-22 18:00 ` [PATCH net 3/3] net: ipa: use state to determine event ring " Alex Elder
2020-12-23 20:20 ` [PATCH net 0/3] net: ipa: GSI interrupt handling fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012270214.QSf8qfSp-lkp@intel.com \
--to=lkp@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).